From: ludo@gnu.org (Ludovic Courtès)
To: ng0 <ng0@infotropique.org>
Cc: 29306@debbugs.gnu.org
Subject: [bug#29306] network-manager-vpnc
Date: Thu, 16 Nov 2017 10:25:27 +0100 [thread overview]
Message-ID: <8760aak22g.fsf@gnu.org> (raw)
In-Reply-To: <20171115104514.uxmsrft73kxhepgt@abyayala> (ng0@infotropique.org's message of "Wed, 15 Nov 2017 10:45:14 +0000")
Heya ng0,
ng0 <ng0@infotropique.org> skribis:
> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@infotropique.org>
> Date: Wed, 15 Nov 2017 10:40:46 +0000
> Subject: [PATCH] gnu: Add network-manager-vpnc.
>
> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.
I don’t think this patch is crude. :-)
Minor issues:
> + (arguments
> + '(#:tests? #f ;test-import-export is failing
Do you think you could investigate a bit?
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-Makefile
> + (lambda _
> + (substitute* "nm-vpnc-service.conf"
> + (("own_prefix")
> + "own")))))))
Please add a comment explaining what this does.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("pkg-config" ,pkg-config)
> + ("libtool" ,libtool)
> + ("intltool" ,intltool)))
Autoconf/Automake/Libtool are probably unnecessary.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2017-11-16 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 10:45 [bug#29306] network-manager-vpnc ng0
2017-11-16 9:25 ` Ludovic Courtès [this message]
2019-06-17 10:26 ` Jelle Licht
2019-06-17 13:37 ` Ludovic Courtès
2019-06-17 14:05 ` ng0
2020-03-15 16:22 ` bug#29306: network-manager-vpnc Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760aak22g.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29306@debbugs.gnu.org \
--cc=ng0@infotropique.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).