From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eFGQy-0005tV-VV
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:26:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eFGQv-0007Kd-0d
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:26:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33881)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eFGQu-0007KJ-S1
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:26:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eFGQs-00088J-I7
	for guix-patches@gnu.org; Thu, 16 Nov 2017 04:26:04 -0500
Subject: [bug#29306] network-manager-vpnc
Resent-Message-ID: <handler.29306.B29306.151082433331210@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171115104514.uxmsrft73kxhepgt@abyayala>
Date: Thu, 16 Nov 2017 10:25:27 +0100
In-Reply-To: <20171115104514.uxmsrft73kxhepgt@abyayala>
	(ng0@infotropique.org's message of "Wed, 15 Nov 2017 10:45:14 +0000")
Message-ID: <8760aak22g.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: ng0 <ng0@infotropique.org>
Cc: 29306@debbugs.gnu.org

Heya ng0,

ng0 <ng0@infotropique.org> skribis:

> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@infotropique.org>
> Date: Wed, 15 Nov 2017 10:40:46 +0000
> Subject: [PATCH] gnu: Add network-manager-vpnc.
>
> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.

I don=E2=80=99t think this patch is crude.  :-)

Minor issues:

> +    (arguments
> +     '(#:tests? #f ;test-import-export is failing

Do you think you could investigate a bit?

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-Makefile
> +           (lambda _
> +             (substitute* "nm-vpnc-service.conf"
> +               (("own_prefix")
> +                "own")))))))

Please add a comment explaining what this does.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("pkg-config" ,pkg-config)
> +       ("libtool" ,libtool)
> +       ("intltool" ,intltool)))

Autoconf/Automake/Libtool are probably unnecessary.

Otherwise LGTM, thanks!

Ludo=E2=80=99.