* [bug#29719] [PATCH] gnu: virtualization: Add lookingglass.
@ 2017-12-15 11:02 Rutger Helling
2017-12-15 14:16 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Rutger Helling @ 2017-12-15 11:02 UTC (permalink / raw)
To: 29719
[-- Attachment #1.1: Type: text/plain, Size: 41 bytes --]
Hey Guix,
this patch adds LookingGlass.
[-- Attachment #1.2: Type: text/html, Size: 234 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-virtualization-Add-lookingglass.patch --]
[-- Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass.patch, Size: 2676 bytes --]
From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Fri, 15 Dec 2017 11:58:10 +0100
Subject: [PATCH] gnu: virtualization: Add lookingglass.
* gnu/packages/virtualization.scm (lookingglass): New variable.
---
gnu/packages/virtualization.scm | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 85563dde6..d3531da69 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -36,6 +36,7 @@
#:use-module (gnu packages dns)
#:use-module (gnu packages docbook)
#:use-module (gnu packages documentation)
+ #:use-module (gnu packages fontutils)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
@@ -709,3 +710,43 @@ mainly implemented in user space.")
incremental backups of running QEMU virtual machines via QMP, the QEMU
Machine Protocol.")
(license gpl3+)))
+
+(define-public lookingglass
+ (package
+ (name "lookingglass")
+ (version "a5")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version))
+ (sha256
+ (base32
+ "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
+ (build-system gnu-build-system)
+ (inputs `(("fontconfig" ,fontconfig)
+ ("glu" ,glu)
+ ("mesa" ,mesa)
+ ("openssl" ,openssl)
+ ("sdl2" ,sdl2)
+ ("sdl2-ttf" ,sdl2-ttf)
+ ("spice-protocol" ,spice-protocol)))
+ (native-inputs `(("pkg-config", pkg-config)))
+ (arguments
+ `(#:tests? #f ;; No tests are available.
+ #:phases (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (chdir "client")))
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (mkdir-p (string-append %output "/bin"))
+ (copy-file "bin/looking-glass-client" (string-append
+ %output "/bin/looking-glass-client")))))))
+ (home-page "https://looking-glass.hostfission.com")
+ (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI
+passthrough")
+ (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay)
+implementation for QEMU guests with VGA PCI Passthrough.")
+ (license gpl2)))
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#29719] [PATCH] gnu: virtualization: Add lookingglass.
2017-12-15 11:02 [bug#29719] [PATCH] gnu: virtualization: Add lookingglass Rutger Helling
@ 2017-12-15 14:16 ` Ludovic Courtès
2017-12-15 15:05 ` Rutger Helling
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-12-15 14:16 UTC (permalink / raw)
To: Rutger Helling; +Cc: 29719
Hello!
Rutger Helling <rhelling@mykolab.com> skribis:
> From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Fri, 15 Dec 2017 11:58:10 +0100
> Subject: [PATCH] gnu: virtualization: Add lookingglass.
>
> * gnu/packages/virtualization.scm (lookingglass): New variable.
[...]
> +(define-public lookingglass
> + (package
> + (name "lookingglass")
Please run:
./etc/indent-code.el gnu/packages/virtualization.scm lookingglass
> + (version "a5")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version))
> + (sha256
> + (base32
> + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
> + (build-system gnu-build-system)
> + (inputs `(("fontconfig" ,fontconfig)
> + ("glu" ,glu)
> + ("mesa" ,mesa)
> + ("openssl" ,openssl)
> + ("sdl2" ,sdl2)
> + ("sdl2-ttf" ,sdl2-ttf)
> + ("spice-protocol" ,spice-protocol)))
> + (native-inputs `(("pkg-config", pkg-config)))
> + (arguments
> + `(#:tests? #f ;; No tests are available.
> + #:phases (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (chdir "client")))
Return #t.
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (mkdir-p (string-append %output "/bin"))
> + (copy-file "bin/looking-glass-client" (string-append
> + %output "/bin/looking-glass-client")))))))
Same here.
Use the ‘outputs’ argument instead of the ‘%output’ global variable.
Also, you can replace the mkdir-p/copy-file pair with just:
(install-file "bin/looking-glass-client"
(string-append (assoc-ref outputs "out") "/bin"))
> + (home-page "https://looking-glass.hostfission.com")
> + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI
> +passthrough")
> + (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay)
> +implementation for QEMU guests with VGA PCI Passthrough.")
Could you shorten the synopsis and expound the description a little bit?
:-) I find it hard to understand what this is about looking at this.
> + (license gpl2)))
AFAICS source file headers explicitly say “or any later version”, so
this should be ‘gpl2+’.
The rest LGTM. Could you send an updated patch?
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#29719] [PATCH] gnu: virtualization: Add lookingglass.
2017-12-15 14:16 ` Ludovic Courtès
@ 2017-12-15 15:05 ` Rutger Helling
2017-12-15 15:11 ` Rutger Helling
0 siblings, 1 reply; 5+ messages in thread
From: Rutger Helling @ 2017-12-15 15:05 UTC (permalink / raw)
To: ludo; +Cc: 29719
[-- Attachment #1.1: Type: text/plain, Size: 2923 bytes --]
Thanks for reviewing! Here's an updated patch based on your feedback.
On 2017-12-15 15:16, ludo@gnu.org wrote:
> Hello!
>
> Rutger Helling <rhelling@mykolab.com> skribis:
>
>> From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001
>> From: Rutger Helling <rhelling@mykolab.com>
>> Date: Fri, 15 Dec 2017 11:58:10 +0100
>> Subject: [PATCH] gnu: virtualization: Add lookingglass.
>>
>> * gnu/packages/virtualization.scm (lookingglass): New variable.
>
> [...]
>
>> +(define-public lookingglass
>> + (package
>> + (name "lookingglass")
>
> Please run:
>
> ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass
>
>> + (version "a5")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
>> + version ".tar.gz"))
>> + (file-name (string-append name "-" version))
>> + (sha256
>> + (base32
>> + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
>> + (build-system gnu-build-system)
>> + (inputs `(("fontconfig" ,fontconfig)
>> + ("glu" ,glu)
>> + ("mesa" ,mesa)
>> + ("openssl" ,openssl)
>> + ("sdl2" ,sdl2)
>> + ("sdl2-ttf" ,sdl2-ttf)
>> + ("spice-protocol" ,spice-protocol)))
>> + (native-inputs `(("pkg-config", pkg-config)))
>> + (arguments
>> + `(#:tests? #f ;; No tests are available.
>> + #:phases (modify-phases %standard-phases
>> + (replace 'configure
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (chdir "client")))
>
> Return #t.
>
>> + (replace 'install
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (mkdir-p (string-append %output "/bin"))
>> + (copy-file "bin/looking-glass-client" (string-append
>> + %output "/bin/looking-glass-client")))))))
>
> Same here.
>
> Use the 'outputs' argument instead of the '%output' global variable.
>
> Also, you can replace the mkdir-p/copy-file pair with just:
>
> (install-file "bin/looking-glass-client"
> (string-append (assoc-ref outputs "out") "/bin"))
>
>> + (home-page "https://looking-glass.hostfission.com")
>> + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI
>> +passthrough")
>> + (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay)
>> +implementation for QEMU guests with VGA PCI Passthrough.")
>
> Could you shorten the synopsis and expound the description a little bit?
> :-) I find it hard to understand what this is about looking at this.
>
>> + (license gpl2)))
>
> AFAICS source file headers explicitly say "or any later version", so
> this should be 'gpl2+'.
>
> The rest LGTM. Could you send an updated patch?
>
> Thank you!
>
> Ludo'.
[-- Attachment #1.2: Type: text/html, Size: 6311 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-virtualization-Add-lookingglass-v2.patch --]
[-- Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass-v2.patch, Size: 2783 bytes --]
From 01501ecf05cf962ee9129c51b7af1087de7e43ae Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Fri, 15 Dec 2017 16:01:28 +0100
Subject: [PATCH] gnu: virtualization: Add lookingglass.
* gnu/packages/virtualization.scm (lookingglass): New variable.
---
gnu/packages/virtualization.scm | 44 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 85563dde6..83a58c17c 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -36,6 +36,7 @@
#:use-module (gnu packages dns)
#:use-module (gnu packages docbook)
#:use-module (gnu packages documentation)
+ #:use-module (gnu packages fontutils)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
@@ -709,3 +710,46 @@ mainly implemented in user space.")
incremental backups of running QEMU virtual machines via QMP, the QEMU
Machine Protocol.")
(license gpl3+)))
+
+(define-public lookingglass
+ (package
+ (name "lookingglass")
+ (version "a5")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version))
+ (sha256
+ (base32
+ "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
+ (build-system gnu-build-system)
+ (inputs `(("fontconfig" ,fontconfig)
+ ("glu" ,glu)
+ ("mesa" ,mesa)
+ ("openssl" ,openssl)
+ ("sdl2" ,sdl2)
+ ("sdl2-ttf" ,sdl2-ttf)
+ ("spice-protocol" ,spice-protocol)))
+ (native-inputs `(("pkg-config", pkg-config)))
+ (arguments
+ `(#:tests? #f ;; No tests are available.
+ #:phases (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (chdir "client")
+ #t))
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (install-file "bin/looking-glass-client"
+ (string-append (assoc-ref outputs "out")
+ "/bin"))
+ #t)))))
+ (home-page "https://looking-glass.hostfission.com")
+ (synopsis "KVM Frame Relay (KVMFR) implementation")
+ (description "Looking Glass allows the use of a KVM (Kernel-based Virtual
+Machine) configured for VGA PCI Pass-through without an attached physical
+monitor, keyboard or mouse. It displays the VM's rendered contents on your main
+monitor/GPU.")
+ (license gpl2+)))
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#29719] [PATCH] gnu: virtualization: Add lookingglass.
2017-12-15 15:05 ` Rutger Helling
@ 2017-12-15 15:11 ` Rutger Helling
2017-12-15 15:39 ` bug#29719: " Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Rutger Helling @ 2017-12-15 15:11 UTC (permalink / raw)
To: ludo; +Cc: 29719
[-- Attachment #1.1: Type: text/plain, Size: 3020 bytes --]
Forgot to put two spaces in the lines for the description.
Here's the proper patch, sorry about that.
On 2017-12-15 16:05, Rutger Helling wrote:
> Thanks for reviewing! Here's an updated patch based on your feedback.
>
> On 2017-12-15 15:16, ludo@gnu.org wrote:
> Hello!
>
> Rutger Helling <rhelling@mykolab.com> skribis:
>
> From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Fri, 15 Dec 2017 11:58:10 +0100
> Subject: [PATCH] gnu: virtualization: Add lookingglass.
>
> * gnu/packages/virtualization.scm (lookingglass): New variable.
> [...]
>
> +(define-public lookingglass
> + (package
> + (name "lookingglass")
> Please run:
>
> ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass
>
> + (version "a5")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version))
> + (sha256
> + (base32
> + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
> + (build-system gnu-build-system)
> + (inputs `(("fontconfig" ,fontconfig)
> + ("glu" ,glu)
> + ("mesa" ,mesa)
> + ("openssl" ,openssl)
> + ("sdl2" ,sdl2)
> + ("sdl2-ttf" ,sdl2-ttf)
> + ("spice-protocol" ,spice-protocol)))
> + (native-inputs `(("pkg-config", pkg-config)))
> + (arguments
> + `(#:tests? #f ;; No tests are available.
> + #:phases (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (chdir "client")))
> Return #t.
>
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (mkdir-p (string-append %output "/bin"))
> + (copy-file "bin/looking-glass-client" (string-append
> + %output "/bin/looking-glass-client")))))))
> Same here.
>
> Use the 'outputs' argument instead of the '%output' global variable.
>
> Also, you can replace the mkdir-p/copy-file pair with just:
>
> (install-file "bin/looking-glass-client"
> (string-append (assoc-ref outputs "out") "/bin"))
>
> + (home-page "https://looking-glass.hostfission.com")
> + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI
> +passthrough")
> + (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay)
> +implementation for QEMU guests with VGA PCI Passthrough.")
> Could you shorten the synopsis and expound the description a little bit?
> :-) I find it hard to understand what this is about looking at this.
>
> + (license gpl2)))
> AFAICS source file headers explicitly say "or any later version", so
> this should be 'gpl2+'.
>
> The rest LGTM. Could you send an updated patch?
>
> Thank you!
>
> Ludo'.
[-- Attachment #1.2: Type: text/html, Size: 6518 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-virtualization-Add-lookingglass-v3.patch --]
[-- Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass-v3.patch, Size: 2784 bytes --]
From 479db2f11837a175598fcc04cc07bee030f17fb1 Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Fri, 15 Dec 2017 16:08:30 +0100
Subject: [PATCH] gnu: virtualization: Add lookingglass.
* gnu/packages/virtualization.scm (lookingglass): New variable.
---
gnu/packages/virtualization.scm | 44 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 85563dde6..2fcd9e5a7 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -36,6 +36,7 @@
#:use-module (gnu packages dns)
#:use-module (gnu packages docbook)
#:use-module (gnu packages documentation)
+ #:use-module (gnu packages fontutils)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
@@ -709,3 +710,46 @@ mainly implemented in user space.")
incremental backups of running QEMU virtual machines via QMP, the QEMU
Machine Protocol.")
(license gpl3+)))
+
+(define-public lookingglass
+ (package
+ (name "lookingglass")
+ (version "a5")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version))
+ (sha256
+ (base32
+ "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
+ (build-system gnu-build-system)
+ (inputs `(("fontconfig" ,fontconfig)
+ ("glu" ,glu)
+ ("mesa" ,mesa)
+ ("openssl" ,openssl)
+ ("sdl2" ,sdl2)
+ ("sdl2-ttf" ,sdl2-ttf)
+ ("spice-protocol" ,spice-protocol)))
+ (native-inputs `(("pkg-config", pkg-config)))
+ (arguments
+ `(#:tests? #f ;; No tests are available.
+ #:phases (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (chdir "client")
+ #t))
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (install-file "bin/looking-glass-client"
+ (string-append (assoc-ref outputs "out")
+ "/bin"))
+ #t)))))
+ (home-page "https://looking-glass.hostfission.com")
+ (synopsis "KVM Frame Relay (KVMFR) implementation")
+ (description "Looking Glass allows the use of a KVM (Kernel-based Virtual
+Machine) configured for VGA PCI Pass-through without an attached physical
+monitor, keyboard or mouse. It displays the VM's rendered contents on your main
+monitor/GPU.")
+ (license gpl2+)))
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#29719: [PATCH] gnu: virtualization: Add lookingglass.
2017-12-15 15:11 ` Rutger Helling
@ 2017-12-15 15:39 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-12-15 15:39 UTC (permalink / raw)
To: Rutger Helling; +Cc: 29719-done
Rutger Helling <rhelling@mykolab.com> skribis:
> From 479db2f11837a175598fcc04cc07bee030f17fb1 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Fri, 15 Dec 2017 16:08:30 +0100
> Subject: [PATCH] gnu: virtualization: Add lookingglass.
>
> * gnu/packages/virtualization.scm (lookingglass): New variable.
Applied, thanks!
Ludo'.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-15 15:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-15 11:02 [bug#29719] [PATCH] gnu: virtualization: Add lookingglass Rutger Helling
2017-12-15 14:16 ` Ludovic Courtès
2017-12-15 15:05 ` Rutger Helling
2017-12-15 15:11 ` Rutger Helling
2017-12-15 15:39 ` bug#29719: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).