From: ludo@gnu.org (Ludovic Courtès)
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 29732@debbugs.gnu.org, "Clément Lassieur" <clement@lassieur.org>
Subject: [bug#29732] [PATCH 1/1] services: Add dhcpd-service-type and <dhcpd-configuration>.
Date: Wed, 18 Apr 2018 22:28:33 +0200 [thread overview]
Message-ID: <87604ow972.fsf@gnu.org> (raw)
In-Reply-To: <87po2yfkj3.fsf_-_@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> (Chris Marusich's message of "Mon, 16 Apr 2018 22:51:12 -0700")
Hello Chris,
Chris Marusich <cmmarusich@gmail.com> skribis:
> Here's a new patch. It mainly tidies up some formatting, makes it
> possible to run more than one version of the DHCP daemon at the same
> time (e.g., for IPv4, IPv6, and IPv4 over IPv6), and adds a system test
> to verify that the DHCPv4 daemon can start up without error.
>
> I tried adding a test case for DHCPv6, but I ran into complications.
> Specifically, I'm not sure how to give an IPv6 address and subnet to the
> eth0 interface within the test VM using the static-networking-service.
> The DHCPv6 daemon requires the interface to have an IPv6 subnet
> configured, so it refuses to run on that interface.
OK.
> For now, it's nice enough, I think, that we have a DHCPv4 system test!
> Please let me know what you think.
I agree, nice job!
> From 5dd2e6853f1a332e55f3a4ba69b9baf199458fcb Mon Sep 17 00:00:00 2001
> From: Chris Marusich <cmmarusich@gmail.com>
> Date: Sat, 16 Dec 2017 00:52:42 -0800
> Subject: [PATCH] services: Add dhcpd-service-type and <dhcpd-configuration>.
>
> * doc/guix.texi (Networking Services): Document it.
> * gnu/services/networking.scm (dhcpd-service-type): Add it.
> (dhcpd-configuration, dhcpd-configuration?): Add it.
> (dhcpd-configuration-package): Add it.
> (dhcpd-configuration-config-file): Add it.
> (dhcpd-configuration-version): Add it.
> (dhcpd-configuration-run-directory): Add it.
> (dhcpd-configuration-lease-file): Add it.
> (dhcpd-configuration-pid-file): Add it.
> (dhcpd-configuration-interfaces): Add it.
> ---
> doc/guix.texi | 17 +++++++
> gnu/services/networking.scm | 80 ++++++++++++++++++++++++++++++
> gnu/tests/networking.scm | 97 ++++++++++++++++++++++++++++++++++++-
Please mention the gnu/tests/networking.scm changes in the log.
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2018-04-18 20:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 8:35 [bug#29732] [PATCH 0/1] Add a DHCP daemon service Chris Marusich
2017-12-16 8:52 ` [bug#29732] [PATCH 1/1] services: Add dhcpd-service-type and <dhcpd-configuration> Chris Marusich
2018-02-27 10:31 ` Clément Lassieur
2018-04-13 7:41 ` Chris Marusich
2018-04-13 9:02 ` Clément Lassieur
2018-04-17 5:51 ` Chris Marusich
2018-04-18 20:28 ` Ludovic Courtès [this message]
2018-04-22 7:44 ` bug#29732: " Chris Marusich
2017-12-16 22:05 ` [bug#29732] [PATCH 0/1] Add a DHCP daemon service Christopher Baines
2017-12-19 7:33 ` Chris Marusich
2018-02-27 9:48 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87604ow972.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29732@debbugs.gnu.org \
--cc=clement@lassieur.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).