From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8thQ-0005UU-PM for guix-patches@gnu.org; Wed, 18 Apr 2018 16:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8thO-0002np-5a for guix-patches@gnu.org; Wed, 18 Apr 2018 16:29:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8thO-0002nh-1j for guix-patches@gnu.org; Wed, 18 Apr 2018 16:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8thN-0002v8-OI for guix-patches@gnu.org; Wed, 18 Apr 2018 16:29:01 -0400 Subject: [bug#29732] [PATCH 1/1] services: Add dhcpd-service-type and . Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171216083528.2081-1-cmmarusich@gmail.com> <20171216085242.2309-1-cmmarusich@gmail.com> <871sh6rafl.fsf@lassieur.org> <87efjjwo25.fsf@gmail.com> <20171216083528.2081-1-cmmarusich@gmail.com> <87d13epbvn.fsf@cbaines.net> <87k1xji33m.fsf@gmail.com> <87bmen32et.fsf@lassieur.org> <87po2yfkj3.fsf_-_@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> Date: Wed, 18 Apr 2018 22:28:33 +0200 In-Reply-To: <87po2yfkj3.fsf_-_@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> (Chris Marusich's message of "Mon, 16 Apr 2018 22:51:12 -0700") Message-ID: <87604ow972.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 29732@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Hello Chris, Chris Marusich skribis: > Here's a new patch. It mainly tidies up some formatting, makes it > possible to run more than one version of the DHCP daemon at the same > time (e.g., for IPv4, IPv6, and IPv4 over IPv6), and adds a system test > to verify that the DHCPv4 daemon can start up without error. > > I tried adding a test case for DHCPv6, but I ran into complications. > Specifically, I'm not sure how to give an IPv6 address and subnet to the > eth0 interface within the test VM using the static-networking-service. > The DHCPv6 daemon requires the interface to have an IPv6 subnet > configured, so it refuses to run on that interface. OK. > For now, it's nice enough, I think, that we have a DHCPv4 system test! > Please let me know what you think. I agree, nice job! > From 5dd2e6853f1a332e55f3a4ba69b9baf199458fcb Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Sat, 16 Dec 2017 00:52:42 -0800 > Subject: [PATCH] services: Add dhcpd-service-type and . > > * doc/guix.texi (Networking Services): Document it. > * gnu/services/networking.scm (dhcpd-service-type): Add it. > (dhcpd-configuration, dhcpd-configuration?): Add it. > (dhcpd-configuration-package): Add it. > (dhcpd-configuration-config-file): Add it. > (dhcpd-configuration-version): Add it. > (dhcpd-configuration-run-directory): Add it. > (dhcpd-configuration-lease-file): Add it. > (dhcpd-configuration-pid-file): Add it. > (dhcpd-configuration-interfaces): Add it. > --- > doc/guix.texi | 17 +++++++ > gnu/services/networking.scm | 80 ++++++++++++++++++++++++++++++ > gnu/tests/networking.scm | 97 ++++++++++++++++++++++++++++++++++++- Please mention the gnu/tests/networking.scm changes in the log. Otherwise LGTM, thank you! Ludo=E2=80=99.