From: "Ludovic Courtès" <ludo@gnu.org>
To: Tim Gesthuizen <tim.gesthuizen@yahoo.de>
Cc: 37750-done@debbugs.gnu.org
Subject: bug#37750: Fixup: Documentation
Date: Mon, 21 Oct 2019 23:05:23 +0200 [thread overview]
Message-ID: <875zkhzu5o.fsf@gnu.org> (raw)
In-Reply-To: <87blujb46u.fsf@yahoo.de> (Tim Gesthuizen's message of "Mon, 14 Oct 2019 19:57:29 +0200")
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Hi Tim,
Tim Gesthuizen <tim.gesthuizen@yahoo.de> skribis:
>>From 544ae60c79134be980d6ee0430deb6abe4cad8ca Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen@yahoo.de>
> Date: Thu, 10 Oct 2019 18:38:36 +0200
> Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service
>
> * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate field.
> (inputattach-shepherd-service): Add baud-rate to parameters when specified.
> * doc/guix.texi (Miscellaneous Services): [inputattach Service] Document
> baud-rate parameter.
Neat. I took the liberty to apply it with the minor change below (we
don’t usually call ‘error’; eventually I think we should use contracts à
la Racket in such situations.)
Thanks!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 773 bytes --]
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 20e89c0dea..08acb79ed6 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1037,9 +1037,7 @@ as expected.")))
(match-lambda
(($ <inputattach-configuration> type device baud-rate log-file)
(let ((args (append (if baud-rate
- (if (number? baud-rate)
- (list "--baud-rate" (number->string baud-rate))
- (error "Expected baud-rate to be a number or #f" baud-rate))
+ (list "--baud-rate" (number->string baud-rate))
'())
(list (string-append "--" type)
device))))
prev parent reply other threads:[~2019-10-21 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 17:30 [bug#37750] inputattach: Add baud rate option Tim Gesthuizen via Guix-patches via
2019-10-14 17:57 ` [bug#37750] Fixup: Documentation Tim Gesthuizen via Guix-patches via
2019-10-21 21:05 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zkhzu5o.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37750-done@debbugs.gnu.org \
--cc=tim.gesthuizen@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).