From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43525) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMesO-0001SK-Qq for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMesM-0001sw-MM for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49155) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMesM-0001sp-E9 for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMesM-0005IB-7v for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:02 -0400 Subject: bug#37750: Fixup: Documentation Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87d0ezb5g1.fsf@yahoo.de> <87blujb46u.fsf@yahoo.de> Date: Mon, 21 Oct 2019 23:05:23 +0200 In-Reply-To: <87blujb46u.fsf@yahoo.de> (Tim Gesthuizen's message of "Mon, 14 Oct 2019 19:57:29 +0200") Message-ID: <875zkhzu5o.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tim Gesthuizen Cc: 37750-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Tim, Tim Gesthuizen skribis: >>>From 544ae60c79134be980d6ee0430deb6abe4cad8ca Mon Sep 17 00:00:00 2001 > From: Tim Gesthuizen > Date: Thu, 10 Oct 2019 18:38:36 +0200 > Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service > > * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate fie= ld. > (inputattach-shepherd-service): Add baud-rate to parameters when specif= ied. > * doc/guix.texi (Miscellaneous Services): [inputattach Service] Document > baud-rate parameter. Neat. I took the liberty to apply it with the minor change below (we don=E2=80=99t usually call =E2=80=98error=E2=80=99; eventually I think we s= hould use contracts =C3=A0 la Racket in such situations.) Thanks! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index 20e89c0dea..08acb79ed6 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1037,9 +1037,7 @@ as expected."))) (match-lambda (($ type device baud-rate log-file) (let ((args (append (if baud-rate - (if (number? baud-rate) - (list "--baud-rate" (number->string baud-rate)) - (error "Expected baud-rate to be a number or #f" baud-rate)) + (list "--baud-rate" (number->string baud-rate)) '()) (list (string-append "--" type) device)))) --=-=-=--