unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme.
@ 2020-07-21  6:08 Jesse Gibbons
  2020-07-25 15:28 ` Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Jesse Gibbons @ 2020-07-21  6:08 UTC (permalink / raw)
  To: 42455

* gnu/packages/video.scm (ffmpeg):
[inputs]: Add libgme.
[arguments]: Pass "--enable-libgme" to configure.
---
gnu/packages/video.scm | 2 ++
1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 6b57d384e1..cbb8e76949 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -963,6 +963,7 @@ operate properly.")
("libcaca" ,libcaca)
("libcdio-paranoia" ,libcdio-paranoia)
("libdrm" ,libdrm)
+ ("libgme" ,libgme)
("libtheora" ,libtheora)
("libva" ,libva)
("libvdpau" ,libvdpau)
@@ -1057,6 +1058,7 @@ operate properly.")
"--enable-libcdio"
"--enable-libdav1d"
"--enable-libfreetype"
+ "--enable-libgme"
"--enable-libmp3lame"
"--enable-libopus"
"--enable-libpulse"




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme.
  2020-07-21  6:08 [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme Jesse Gibbons
@ 2020-07-25 15:28 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2020-07-25 15:28 UTC (permalink / raw)
  To: Jesse Gibbons, 42455

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

Jesse Gibbons <jgibbons2357@gmail.com> writes:

> * gnu/packages/video.scm (ffmpeg):
> [inputs]: Add libgme.
> [arguments]: Pass "--enable-libgme" to configure.

'libgme' appears to keep a reference to 'gcc':

$ guix size libgme 
store item                          total    self
/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0              178.5   107.3  59.1%    <--- this should not be here
/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31              38.4    36.7  20.2%
/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib           71.0    32.6  18.0%
/gnu/store/483hgxdmnhh2jh471d0x3aywqrpfp36k-libgme-0.6.3           181.6     3.1   1.7%
/gnu/store/mmhimfwmmidf09jw1plw3aw1g1zn2nkh-bash-static-5.0.16       1.6     1.6   0.9%
/gnu/store/g2s5jfkfd4k973wb58476b1bbv9zpm6m-zlib-1.2.11             38.6     0.2   0.1%
total: 181.6 MiB

Thus adding it to ffmpeg would increase the closure size of ffmpeg by
more than 100MiB (compare 'guix size ffmpeg' and
'guix size libgme ffmpeg').

We should sort out that GCC reference first.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-25 15:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21  6:08 [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme Jesse Gibbons
2020-07-25 15:28 ` Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).