From: Sergey Trofimov <sarg@sarg.org.ru>
To: 46337@debbugs.gnu.org
Subject: [bug#46337] Clarification for the previous patch
Date: Sun, 30 May 2021 20:47:38 +0200 [thread overview]
Message-ID: <875yz05a9i.fsf@sarg.org.ru> (raw)
In-Reply-To: <20210206014748.5b281d65@runbox.com>
Hey there. Just to clarify why and how this patch works:
When `-webengine-proprietary-codecs` flag is added `rtc_use_h264`
gn arg would be enabled. [1]
This flag under the hood adds dependency on openh264 (to encode
webrtc streams). [2]
Now to make the build accept system library we have to jump
through some hoops:
- List of config flags [3] which qtwebengine supports misses
webengine-system-openh264
- Chromium on the other hand supports linking with system library.
[4]
- To pass the required GN arg I blatantly slap it in linux.pri to
gn_args
[1]
https://github.com/qt/qtwebengine/blob/v5.15.2/src/core/config/common.pri#L31
[2]
https://github.com/qt/qtwebengine-chromium/blob/88-based/chromium/third_party/webrtc/modules/video_coding/BUILD.gn#L402
[3]
https://github.com/qt/qtwebengine/blob/v5.15.2/src/buildtools/configure.json#L763
[4]
https://github.com/qt/qtwebengine-chromium/blob/88-based/chromium/third_party/openh264/openh264_args.gni
next prev parent reply other threads:[~2021-05-30 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 1:47 [bug#46337] A patch to enable building proprietary codecs in qtwebengine pkill9
2021-02-06 10:10 ` Tobias Geerinckx-Rice via Guix-patches via
2021-02-06 13:05 ` Tobias Geerinckx-Rice via Guix-patches via
2021-02-07 18:12 ` Leo Famulari
2021-02-08 15:40 ` pkill9
2021-02-08 16:36 ` Leo Famulari
2021-02-08 22:53 ` pkill9
2021-02-08 23:44 ` pkill9
2021-02-09 21:17 ` Leo Famulari
2021-05-30 17:54 ` [bug#46337] Attempt to fix the build Sergey Trofimov
2021-06-07 21:01 ` bug#46337: " Leo Famulari
2021-05-30 18:47 ` Sergey Trofimov [this message]
2021-05-30 20:00 ` [bug#46337] Update Sergey Trofimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yz05a9i.fsf@sarg.org.ru \
--to=sarg@sarg.org.ru \
--cc=46337@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).