From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KFVtJOnds2BBVAAAgWs5BA (envelope-from ) for ; Sun, 30 May 2021 20:48:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OA7HH+nds2BhWgAAbx9fmQ (envelope-from ) for ; Sun, 30 May 2021 18:48:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF177178F8 for ; Sun, 30 May 2021 20:48:08 +0200 (CEST) Received: from localhost ([::1]:36100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnQTn-0007Ia-Q0 for larch@yhetil.org; Sun, 30 May 2021 14:48:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnQTi-0007IR-HM for guix-patches@gnu.org; Sun, 30 May 2021 14:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnQTi-0003Qe-AE for guix-patches@gnu.org; Sun, 30 May 2021 14:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnQTi-0002JG-87 for guix-patches@gnu.org; Sun, 30 May 2021 14:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46337] Clarification for the previous patch References: <20210206014748.5b281d65@runbox.com> In-Reply-To: <20210206014748.5b281d65@runbox.com> Resent-From: Sergey Trofimov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 May 2021 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46337 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 46337@debbugs.gnu.org Received: via spool by 46337-submit@debbugs.gnu.org id=B46337.16224004308816 (code B ref 46337); Sun, 30 May 2021 18:48:02 +0000 Received: (at 46337) by debbugs.gnu.org; 30 May 2021 18:47:10 +0000 Received: from localhost ([127.0.0.1]:60332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnQSr-0002I8-Ti for submit@debbugs.gnu.org; Sun, 30 May 2021 14:47:10 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:44548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnQSo-0002Hc-J1 for 46337@debbugs.gnu.org; Sun, 30 May 2021 14:47:08 -0400 Received: by mail-wm1-f46.google.com with SMTP id y184-20020a1ce1c10000b02901769b409001so5266373wmg.3 for <46337@debbugs.gnu.org>; Sun, 30 May 2021 11:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sarg.org.ru; s=google; h=user-agent:from:to:subject:message-id:date:mime-version; bh=MRvzN7BRbUOVz41g0ATorf7qOUAzJhuOCYfOxkPiFzg=; b=LG7qVRS9HAqo4TkWrLKFS8UjawTNl0ZHDErKZaCws+e8AkQi/sBqR+d1LhB/c+DPnn ggAMBVYhvwW2QUNRIkwaOAPsUWFfE+bAxSlJMOz9i9+qON9snIzrN4ZNjOQNyprzoLJb 2VJnMReFGf4VmyOT8YLUtbgeEjDP6TWl5epy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:message-id:date :mime-version; bh=MRvzN7BRbUOVz41g0ATorf7qOUAzJhuOCYfOxkPiFzg=; b=kcXs1goIV8nlErqUFFn6QEQeghXsLRtnERweohxz5KSWtHFXdj5SoGqAUGqdwBte4l gPT0XvDs/jKDYWSLbGIfCC9gPmr+pat8eqj85k9GaWB+q3sK22v0moVdS8XyCSpzUoG6 1QhLXpxt6g3drgfQxtXh3V4XRHf5mlML8YRiuIzbtTZloVvaJgv7qaQRPw0IxUU5Dtgk oBm/5oHiYAStmhc7qewjqHIWyzbYLidM5xQqXLLSrPjD4hCjBIS/CcZKCVVMcITsvxS6 xdgaGWkGwivpvyrKGfBarmTrCV/TAgBFqSiE/OGmNo2VEJhnZ5ZeQCXIMlgeOqpby1SV fiuw== X-Gm-Message-State: AOAM533/mxrBkexcA2d1PhmCnXEjvxnyh7VpuKd8QkdefpO2vvlc6GDj DlPWOZ3AaG8QcdOSNTnphjsl/yhWc3o+2g== X-Google-Smtp-Source: ABdhPJwIMsak0/7U8ugAfmpWQTs7fsPnCXAgtDNYCDHEUV15mSQynvMuSNEBKFKyMNvyywiMBVNKvQ== X-Received: by 2002:a7b:c098:: with SMTP id r24mr6539452wmh.35.1622400420066; Sun, 30 May 2021 11:47:00 -0700 (PDT) Received: from localhost ([92.206.237.187]) by smtp.gmail.com with ESMTPSA id v18sm17355701wro.18.2021.05.30.11.46.59 for <46337@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 May 2021 11:46:59 -0700 (PDT) User-agent: mu4e 1.4.15; emacs 28.0.50 From: Sergey Trofimov Message-ID: <875yz05a9i.fsf@sarg.org.ru> Date: Sun, 30 May 2021 20:47:38 +0200 MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622400489; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=MRvzN7BRbUOVz41g0ATorf7qOUAzJhuOCYfOxkPiFzg=; b=sAFGotJuSVVUclmDOxYqgRVkNjNS1k9/JXWYOKk9xnKT1Dg2JcmG59teXqUdjkSfeOUkUO 6R8dUSpFL6nRudVyfEsMygAoKNrkiPZn4+XEAwBvR/8RQsdL7KPdrSjL8SeJcj3Lx+TMuX EdxBwiap2YIxXQ8G7qRTV8wQsyJtzevMgprv8KwpEpCpsmVMD43/QuIq41d3r5kgmH72YZ S6OlvIW6L2xgsgkApWO0tfoHMSEEwwjhEM0Dk77d3vkug2J+i5AGKQ6sUPpEzXCl8cuHec GHmxAfdiAjwqHPGlSp7rdvhyyAoTGdgI7YnuuGHyDY0Od5eOJaAKjFOpEjXlww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622400489; a=rsa-sha256; cv=none; b=FLI6+BukgPCqbiFlQuLiU989NHJJso5WTUpU/KZIqAClR/5UelUOyFDo5EzTa8Egdo2Tw6 qzYzh1lRQ8dXqCZSOCc6XoVUunk8sWzmJyGaCH57bcQV+yHB5msCTDxnzgloAqgbMzl92P UV6RiLycT4Si7MtVMI6gmNGjGHDzoeV3OBJ7t+kR79d2Is5vvGu0NcTfw0+ja0x5jvxYkj 7xl6StLL8a8+O4V9LYZ8uPZsl1nsdu7yo5CDBvhyvPGp6/auXYZv2J5wB4JXRgWZVHB9xR p4z/P1ygJZVDt0n6eNmI5No1rUAzg/Pzj7UXne1cqRU94i9rY0nWQr7k52WQAQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=sarg.org.ru header.s=google header.b=LG7qVRS9; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=sarg.org.ru header.s=google header.b=LG7qVRS9; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BF177178F8 X-Spam-Score: -1.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: qTIDjfzWisJD Hey there. Just to clarify why and how this patch works: When `-webengine-proprietary-codecs` flag is added `rtc_use_h264` gn arg would be enabled. [1] This flag under the hood adds dependency on openh264 (to encode webrtc streams). [2] Now to make the build accept system library we have to jump through some hoops: - List of config flags [3] which qtwebengine supports misses webengine-system-openh264 - Chromium on the other hand supports linking with system library. [4] - To pass the required GN arg I blatantly slap it in linux.pri to gn_args [1] https://github.com/qt/qtwebengine/blob/v5.15.2/src/core/config/common.pri#L31 [2] https://github.com/qt/qtwebengine-chromium/blob/88-based/chromium/third_party/webrtc/modules/video_coding/BUILD.gn#L402 [3] https://github.com/qt/qtwebengine/blob/v5.15.2/src/buildtools/configure.json#L763 [4] https://github.com/qt/qtwebengine-chromium/blob/88-based/chromium/third_party/openh264/openh264_args.gni