* [bug#52893] gnu: add python-lief
@ 2021-12-30 8:52 Michael Ford
2021-12-30 10:02 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ford @ 2021-12-30 8:52 UTC (permalink / raw)
To: 52893
[-- Attachment #1.1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #1.2: Type: text/html, Size: 26 bytes --]
[-- Attachment #2: add_python_lief.patch --]
[-- Type: application/octet-stream, Size: 1109 bytes --]
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 3a9e35aacf..08ab5431f3 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -27844,3 +27844,26 @@ (define-public python-iwlib
(description
"This package provides a Python interface to iw wireless tools.")
(license license:gpl2)))
+
+(define-public lief
+ (package
+ (name "python-lief")
+ (version "0.11.5")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/lief-project/LIEF.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0qahjfg1n0x76ps2mbyljvws1l3qhkqvmxqbahps4qgywl2hbdkj"))))
+ (build-system python-build-system)
+ (native-inputs
+ `(("cmake" ,cmake)))
+ (home-page "https://github.com/lief-project/LIEF")
+ (synopsis "Library to Instrument Executable Formats")
+ (description "Python library to to provide a cross platform library which can
+parse, modify and abstract ELF, PE and MachO formats.")
+ (license license:asl2.0)))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#52893] gnu: add python-lief
2021-12-30 8:52 [bug#52893] gnu: add python-lief Michael Ford
@ 2021-12-30 10:02 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2021-12-30 10:02 UTC (permalink / raw)
To: Michael Ford; +Cc: 52893
Hello,
Michael Ford <fanquake@gmail.com> writes:
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 3a9e35aacf..08ab5431f3 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -27844,3 +27844,26 @@ (define-public python-iwlib
> (description
> "This package provides a Python interface to iw wireless tools.")
> (license license:gpl2)))
> +
> +(define-public lief
Thank you. Some comments follow.
But first and foremost, you need to provide a proper commit message, and
use `git format-patch' to send it to the list. See Contributing section
in the manual, and examples of messages in the commits history of the
probject.
> + (package
> + (name "python-lief")
Package name and variable name are differents, this should be (name
"lief"), since it doesn't seem to be Python specific.
> + (version "0.11.5")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/lief-project/LIEF.git")
You can remove ".git" suffix here.
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0qahjfg1n0x76ps2mbyljvws1l3qhkqvmxqbahps4qgywl2hbdkj"))))
Hash string should go on the same line as base32.
> + (build-system python-build-system)
> + (native-inputs
> + `(("cmake" ,cmake)))
I think this is the other way. You may use cmake-build-system, and
provide python-wrapper as a native input.
> + (home-page "https://github.com/lief-project/LIEF")
> + (synopsis "Library to Instrument Executable Formats")
> + (description "Python library to to provide a cross platform library which can
> +parse, modify and abstract ELF, PE and MachO formats.")
AFAIU, this is not a Python-only library. Besides, the description
should consist of full sentences.
I made the changes suggested above, but couldn't run the tests. Also,
I didn't build documentation. Eventually, the process seems to create
static libraries, it would be nice to remove them. Could you look into
it and see what is possible to do?
--8<---------------cut here---------------start------------->8---
(define-public lief
(package
(name "lief")
(version "0.11.5")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/lief-project/LIEF")
(commit version)))
(file-name (git-file-name name version))
(sha256
(base32 "0qahjfg1n0x76ps2mbyljvws1l3qhkqvmxqbahps4qgywl2hbdkj"))))
(build-system cmake-build-system)
(arguments
`(#:tests? #f ;FIXME: Require git
#:configure-flags (list "-DLIEF_INSTALL_PYTHON=ON")))
(native-inputs
(list python-wrapper))
(home-page "https://github.com/lief-project/LIEF")
(synopsis "Library to Instrument Executable Formats")
(description
"LIEF is a library which can parse, modify and abstract ELF, PE
and MachO formats. It can be used in C, C++ and Python.")
(license license:asl2.0)))
--8<---------------cut here---------------end--------------->8---
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-30 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 8:52 [bug#52893] gnu: add python-lief Michael Ford
2021-12-30 10:02 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).