From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: "Paul A. Patience" <paul@apatience.com>
Cc: "55819@debbugs.gnu.org" <55819@debbugs.gnu.org>
Subject: [bug#55819] [PATCH 0/2] gnu: Add f3d.
Date: Thu, 11 Aug 2022 17:02:53 +0800 [thread overview]
Message-ID: <875yizrw3m.fsf_-_@envs.net> (raw)
In-Reply-To: <FA5kZUe4R1C6dhGsdUQN1WONrIwssPQyO7IW3nAgitOqPoJGoX4ee5zcCXKsH3ZvXFMLtHejIUuMls9cHbvf986lHM4ZXTvoADxH4QVXZMc=@apatience.com> (Paul A. Patience's message of "Thu, 14 Jul 2022 17:06:31 +0000")
"Paul A. Patience" <paul@apatience.com> writes:
Hello, I had pushed those patches, with adjusted f3d synopsis and
description (remove "fast", "minimalistic", "KISS"), and also phases.
> [...]
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'adjust-titles-and-descriptions
> + (lambda _
> + (substitute* '("CMakeLists.txt"
> + "resources/f3d.desktop.in"
> + "resources/io.github.f3d_app.f3d.metainfo.xml")
> + (("A fast and minimalist 3D viewer")
> + "Fast and minimalistic 3D viewer"))
> + (substitute* "resources/io.github.f3d_app.f3d.metainfo.xml"
> + (("it is minimalist,")
> + "it is minimalistic,")
> + (("arguments in the command line\\.")
> + "arguments on the command line."))
> + ;; Keep the title bar short.
> + (substitute* "application/F3DConfig.h.in"
> + (("AppTitle = \"@PROJECT_DESCRIPTION@\";")
> + "AppTitle = \"F3D\";"))))
> + (add-after 'unpack 'fix-typos
> + (lambda _
> + (substitute* '("application/F3DOptionsParser.cxx"
> + "application/F3DStarter.cxx"
> + "cmake/testing.cmake"
> + "library/testing/TestSDKHelpers.h")
> + (("does not exists")
> + "does not exist"))))
> + ;; Skip checking for the relative-to-executable configuration file
> + ;; (located in ../../argv[0]) when the user configuration file
> + ;; doesn't exist, because the check fails and prints a warning
> + ;; message upon each invocation of the program.
> + ;; Besides, the usefulness of this configuration file is unclear
> + ;; because F3D reads /etc/f3d/config.json as a fallback system
> + ;; configuration file.
> + (add-after 'unpack 'ignore-binary-config-file-dir
> + (lambda _
> + (substitute* "application/F3DOptionsParser.cxx"
> + (("^ +filePath = .*->GetBinaryConfigFileDirectory\\(\\) .*")
> + "")))))))
I think those titles, descriptions, typos, and warning should go direct
to the upstream, since they don't change the function of f3d, so I pushed
this patch without those modifications first.
Thank you!
prev parent reply other threads:[~2022-08-11 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 10:58 [bug#55819] [PATCH 0/2] gnu: Add f3d Paul A. Patience
2022-06-06 11:01 ` [bug#55819] [PATCH 1/2] gnu: vtk: Enable the RenderingExternal module Paul A. Patience
2022-06-06 11:01 ` [bug#55819] [PATCH 2/2] gnu: Add f3d Paul A. Patience
2022-06-06 19:57 ` [bug#55819] [PATCH v2 0/2] " Paul A. Patience
2022-06-06 19:57 ` [bug#55819] [PATCH v2 1/2] gnu: vtk: Enable the RenderingExternal module Paul A. Patience
2022-06-06 19:57 ` [bug#55819] [PATCH v2 2/2] gnu: Add f3d Paul A. Patience
2022-07-14 17:06 ` [bug#55819] [PATCH v3] " Paul A. Patience
2022-08-11 9:02 ` 宋文武 via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yizrw3m.fsf_-_@envs.net \
--to=guix-patches@gnu.org \
--cc=55819@debbugs.gnu.org \
--cc=iyzsong@envs.net \
--cc=paul@apatience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).