From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kOvKJ2PG9GLU/gAAbAwnHQ (envelope-from ) for ; Thu, 11 Aug 2022 11:05:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iPuQJ2PG9GILXgAAauVa8A (envelope-from ) for ; Thu, 11 Aug 2022 11:05:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44E0A3A7CD for ; Thu, 11 Aug 2022 11:05:39 +0200 (CEST) Received: from localhost ([::1]:35444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM48I-0006VQ-Fj for larch@yhetil.org; Thu, 11 Aug 2022 05:05:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM46l-0006U3-Sf for guix-patches@gnu.org; Thu, 11 Aug 2022 05:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM46j-0000pF-Vd for guix-patches@gnu.org; Thu, 11 Aug 2022 05:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oM46j-0002zq-Pu for guix-patches@gnu.org; Thu, 11 Aug 2022 05:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55819] [PATCH 0/2] gnu: Add f3d. Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Aug 2022 09:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55819 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Paul A. Patience" Cc: "55819@debbugs.gnu.org" <55819@debbugs.gnu.org> Received: via spool by 55819-submit@debbugs.gnu.org id=B55819.166020859211444 (code B ref 55819); Thu, 11 Aug 2022 09:04:01 +0000 Received: (at 55819) by debbugs.gnu.org; 11 Aug 2022 09:03:12 +0000 Received: from localhost ([127.0.0.1]:51590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM45w-0002yW-0y for submit@debbugs.gnu.org; Thu, 11 Aug 2022 05:03:12 -0400 Received: from envs.net ([89.163.145.170]:43826 helo=mail.envs.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM45q-0002yI-4A for 55819@debbugs.gnu.org; Thu, 11 Aug 2022 05:03:10 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 07FA738A0DF8; Thu, 11 Aug 2022 09:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1660208581; bh=loC2RxR3nBnJm3K7GLS2+Q/GgfVX1YIu1tw03kAsMYw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=e/TSab9ChjGbMui0TedGtUMNsLNGOhwyTrXDc6NI5NJXPl0qz9IH9LO1viXfBuzQN qDA5iWc+QOnirSjxKE7wgY9aLKqC9kHTFaVBEwT6MsH/W98nSsT4XsfAf2ICxjBZnr GCwB2TQE/U+/akMKTtyHISuzZ4+6l1uwaLK6wIk6/cUsDtQJCw4AP1ACKFOVcM+BLB SDSuQXE5msYwRmi4gzqfORLiYQFCGh34MhcYFcF02mkrIv0MEL+HDipXQ10T0mLnKO F0p9EbP9ExWes6NCACiCf/kHYhthfFo6wpKFxbdUNMQNWBS6xB5F/s89ZudV2vyd7T 2QZ/A1GCX9gO9drFYZqqgaYWsxk/HYu6HNghP4Gk+QFEyuvekKb9nm+5t5VppIGQGL scdtIaoNn+TGUunw5/eN5u74fH83Q9AdbhVsRkIlSv9FJNoO7QKVaCJQ1FspDrcmD+ ff0CJ4kK8r5+LwnvxmbD5rO4a4IpxM79JuPiu33nqnnhZ0NykdbwcDh4GSTLIznTK/ w6khZjklwNY+B84xBoUnh5Z2UWEAWpB74NpVUSpHhWXOU3ElYAfQvbWFqyVYxQGPCp Yltccq9wnrDpPqkrr4xAqT3IlitRWDWfqpTahbYfGfLB+H2up9LJuKxjiJM/M+1EW9 wWNyk27bPMGNeYvofjiXWTrs= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tPdNEzDQXKR3; Thu, 11 Aug 2022 09:02:58 +0000 (UTC) Received: from localhost (unknown [182.150.116.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: iyzsong@envs.net) by mail.envs.net (Postfix) with ESMTPSA; Thu, 11 Aug 2022 09:02:57 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 7ec93830; Thu, 11 Aug 2022 09:02:53 +0000 (UTC) References: <20220606105824.901227-1-paul@apatience.com> Date: Thu, 11 Aug 2022 17:02:53 +0800 In-Reply-To: (Paul A. Patience's message of "Thu, 14 Jul 2022 17:06:31 +0000") Message-ID: <875yizrw3m.fsf_-_@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-ACL-Warn: , =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= From: =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660208739; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=loC2RxR3nBnJm3K7GLS2+Q/GgfVX1YIu1tw03kAsMYw=; b=Z/i9yc+8lm9aWiZ8eGwEm7iDKryeZZFAxG3n+FRAW04+U/aKZkhmkIWMwtW3dHVDnmR6UI JPgTmjH7A3n0oa9Aozp6H5/OAxR4xtZ+apV6ii9E5SYgt3AnxWRGkV4XxXeNue7fuby0LE h0NfOG45IpLAe/LDs9EGNY49peWbLbHP3nmV4VkULZq1bFunztEf26mVsXldkhOnkz+BfG LolbrpG860bbCFa/g64k3lYzbKd1vfLcEsRF+OUqHcJxuTXybjqWgEOut8V1GEzfeaNGwT w2Wp/wYOXsMPE1i971mLbLmglodGdRaP2BiCJ5w6kPEQgvvzoJvN2LhS/cnjWg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660208739; a=rsa-sha256; cv=none; b=PBETkt7qLYaI4ZHhL1HsRtxB1zwBr3AjGDjfpP3z4Pdd5A1+/3LzN8z/lvxe9Yxw5A89tD OnyZeSCKxhtDwSvWfdr6s6ufkAV3MalMfLcYWWQYu7t3n8bMVUrqemFIA/Gx2ep+3aCDvY yGykjpCu2hFZzjbYGT+ozU/95Xxo3Gm564h1I8N3iCYPPEI5UM5zryY8QVtUt8R4oU+oVp j5k1J2PbiyMDpbW+BmR525Y5S7+qNvzhWhu5MNHWuDt3IzkKr9/Hfm9r0XnT85Mhs3N8Eh /liXl+KdF1enV75W3gAsiGXfZSykXSX0tvhVtkRZYh99YtFC8R5oqQowz4He7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b="e/TSab9C"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b="e/TSab9C"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 44E0A3A7CD X-Spam-Score: -1.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: lCMa1PA8OhvX "Paul A. Patience" writes: Hello, I had pushed those patches, with adjusted f3d synopsis and description (remove "fast", "minimalistic", "KISS"), and also phases. > [...] > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'adjust-titles-and-descriptions > + (lambda _ > + (substitute* '("CMakeLists.txt" > + "resources/f3d.desktop.in" > + "resources/io.github.f3d_app.f3d.metainfo.xml") > + (("A fast and minimalist 3D viewer") > + "Fast and minimalistic 3D viewer")) > + (substitute* "resources/io.github.f3d_app.f3d.metainfo.xml" > + (("it is minimalist,") > + "it is minimalistic,") > + (("arguments in the command line\\.") > + "arguments on the command line.")) > + ;; Keep the title bar short. > + (substitute* "application/F3DConfig.h.in" > + (("AppTitle = \"@PROJECT_DESCRIPTION@\";") > + "AppTitle = \"F3D\";")))) > + (add-after 'unpack 'fix-typos > + (lambda _ > + (substitute* '("application/F3DOptionsParser.cxx" > + "application/F3DStarter.cxx" > + "cmake/testing.cmake" > + "library/testing/TestSDKHelpers.h") > + (("does not exists") > + "does not exist")))) > + ;; Skip checking for the relative-to-executable configuration file > + ;; (located in ../../argv[0]) when the user configuration file > + ;; doesn't exist, because the check fails and prints a warning > + ;; message upon each invocation of the program. > + ;; Besides, the usefulness of this configuration file is unclear > + ;; because F3D reads /etc/f3d/config.json as a fallback system > + ;; configuration file. > + (add-after 'unpack 'ignore-binary-config-file-dir > + (lambda _ > + (substitute* "application/F3DOptionsParser.cxx" > + (("^ +filePath = .*->GetBinaryConfigFileDirectory\\(\\) .*") > + ""))))))) I think those titles, descriptions, typos, and warning should go direct to the upstream, since they don't change the function of f3d, so I pushed this patch without those modifications first. Thank you!