unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 57945-done@debbugs.gnu.org, Andreas Rammhold <andreas@rammhold.de>
Subject: bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support
Date: Wed, 28 Sep 2022 22:41:34 +0200	[thread overview]
Message-ID: <875yh7fczl.fsf_-_@gnu.org> (raw)
In-Reply-To: <091125b8-f122-46cd-85ae-1aca0cacaf19@telenet.be> (Maxime Devos's message of "Thu, 22 Sep 2022 21:14:56 +0200")

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> On 20-09-2022 01:59, Andreas Rammhold wrote:
>> +           (add-after 'configure 'enable-owe
>> +             (lambda _
>> +               (let ((port (open-file ".config" "al")))
>> +                 (display "CONFIG_OWE=y\n" port)
>> +                 (close-port port))
>> +               #t))
>
>
> (1) Why not do this in the 'configure' phase instead?
> (2) Trailing #t in phases aren't required anymore since a long time,
> you can remove them.
> (3) You are not a committer (and you are the author), so you can't
> 'push the commit on behalf on somebody else'.  From (guix)Commit

Good points (perhaps somewhat intimidating for a newcomer).

Andreas, I applied a variant of the patch that accounts for the comments
Maxime made.

Thank you!

Ludo’.




      parent reply	other threads:[~2022-09-28 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 23:59 [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support Andreas Rammhold
2022-09-22 19:14 ` Maxime Devos
2022-09-22 19:32   ` Maxime Devos
2022-09-28 20:41   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yh7fczl.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=57945-done@debbugs.gnu.org \
    --cc=andreas@rammhold.de \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).