From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YAzcIBy7NGPzJgEAbAwnHQ (envelope-from ) for ; Wed, 28 Sep 2022 23:22:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WMDaIBy7NGPp6wAAauVa8A (envelope-from ) for ; Wed, 28 Sep 2022 23:22:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 453B01BBD5 for ; Wed, 28 Sep 2022 23:22:36 +0200 (CEST) Received: from localhost ([::1]:55920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odeVm-0001Ae-8J for larch@yhetil.org; Wed, 28 Sep 2022 17:22:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oddsb-0002LO-Kc for guix-patches@gnu.org; Wed, 28 Sep 2022 16:42:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oddsa-0000Ih-AU for guix-patches@gnu.org; Wed, 28 Sep 2022 16:42:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oddsZ-00017B-2O for guix-patches@gnu.org; Wed, 28 Sep 2022 16:42:03 -0400 Subject: bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 28 Sep 2022 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57945 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 57945-done@debbugs.gnu.org, Andreas Rammhold Mail-Followup-To: 57945@debbugs.gnu.org, ludo@gnu.org, andreas@rammhold.de Received: via spool by 57945-done@debbugs.gnu.org id=D57945.16643977224269 (code D ref 57945); Wed, 28 Sep 2022 20:42:02 +0000 Received: (at 57945-done) by debbugs.gnu.org; 28 Sep 2022 20:42:02 +0000 Received: from localhost ([127.0.0.1]:34899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oddsV-00016i-QA for submit@debbugs.gnu.org; Wed, 28 Sep 2022 16:42:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oddsG-00016I-C9 for 57945-done@debbugs.gnu.org; Wed, 28 Sep 2022 16:41:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odds9-0000Dv-Au; Wed, 28 Sep 2022 16:41:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jajRPxWe7yHn+t++MpEk3kZ0URLkuVnPOo83JjEWdg4=; b=OS+IHgHERuRnDXmAoRCf zmq92UDyVwmt0FLYOe+opF9UYxEVso3fyNEtF5BpUrdIhnCzl4c2wKs6x6265i/biPH2w0sxKRA2a kB6Nm5vZC61dc1pLP383N9WIZjHmK5USQTRPh4k4N2gK4E6Jz77FFRc2Tp8wyHJ+0qB7wGcLn+x9n F1c29KVZ3ew7VwtLyzfKjSnBnF0KkKSI7If9h4lRr9CaY+y6yg0Ymn/r/S9ajCTm/RpUwIgVa7MvG cMCqADISSKd/cTpeZRPU0J7tjgHMWAKc9GUr/oTXa5q0fMyEWClHeijmxF5CmKGMqJa23AKnCBquu PRk4OpRP6PFwaA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:64190 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odds8-0005uR-Mk; Wed, 28 Sep 2022 16:41:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220919235956.1074718-1-andreas@rammhold.de> <091125b8-f122-46cd-85ae-1aca0cacaf19@telenet.be> Date: Wed, 28 Sep 2022 22:41:34 +0200 In-Reply-To: <091125b8-f122-46cd-85ae-1aca0cacaf19@telenet.be> (Maxime Devos's message of "Thu, 22 Sep 2022 21:14:56 +0200") Message-ID: <875yh7fczl.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664400156; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jajRPxWe7yHn+t++MpEk3kZ0URLkuVnPOo83JjEWdg4=; b=mPI5+7fIC9mnKmmQWAXgL74EvF95PAj0zFD4/D1thp5/RANkIu0rSqCwRag+uf8Kh6tkQN xQXX4ceO5wqv+XTMOwrJpa9Do6y4TWqbtS2kmNZ3IQ6tJe+6fif+B9HngkvI6LdXz0wC6I 4o7wtVFuN39w2llyiJ94HhUsoKhfxUULefoIgQAr87sZXRToJ3cwa0UTYKKpgjlnQfWMJl XrZw7xMOkzu/AZtf1fEXDOD8tLFVsTymOIQvmSQWbrKcfwu5lvDu+YpycIcNiJH8p7hk3k s2oJrs9IUxObpPiJgVlLEYi1CCkh1Lc517YtuuuUrJc89+B7FvJB1Ptehqc8eg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664400156; a=rsa-sha256; cv=none; b=txsbX4KgZCfaQSCd0itWfpZQQO2vF+p5rxvUR4G1HpmiNpZ1evhSGaxDiPavJymtk3gCx5 ZyjECaaxrSA/+DEFHuu9XkVt8/mzKVQyjcXhhRuIZB09tiD/o6tuBCrLX41byX7HuMMX7T Wlt2wLruZ2uKJP0FMhXEq6SnEMb8O1I3HUJS38Uhf9vcsGHPwECIQvTSeZGXwT/E9ZV0B9 mfaWbajSUYi0CjYTjRLXzYVKEA8NyxYEl9Jyx4kw6vO1KSWyoQvJ32W0aH2V2686dOb1MC bP7GS5DPWqA1u8WcUa9fX5zm+7MVn+NOR2qFMwhetDAdJNKSCXBU1btezEZqRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OS+IHgHE; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.75 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OS+IHgHE; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 453B01BBD5 X-Spam-Score: -3.75 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7dgw4SlMtDli Hi, Maxime Devos skribis: > On 20-09-2022 01:59, Andreas Rammhold wrote: >> + (add-after 'configure 'enable-owe >> + (lambda _ >> + (let ((port (open-file ".config" "al"))) >> + (display "CONFIG_OWE=3Dy\n" port) >> + (close-port port)) >> + #t)) > > > (1) Why not do this in the 'configure' phase instead? > (2) Trailing #t in phases aren't required anymore since a long time, > you can remove them. > (3) You are not a committer (and you are the author), so you can't > 'push the commit on behalf on somebody else'. From (guix)Commit Good points (perhaps somewhat intimidating for a newcomer). Andreas, I applied a variant of the patch that accounts for the comments Maxime made. Thank you! Ludo=E2=80=99.