unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Wilko Meyer <w@wmeyer.eu>
Cc: 64875@debbugs.gnu.org, efraim@flashner.co.il
Subject: [bug#64875] [PATCH 0/4] Adding xsv
Date: Wed, 11 Oct 2023 11:16:36 +0100	[thread overview]
Message-ID: <875y3dfon2.fsf@cbaines.net> (raw)
In-Reply-To: <87cyxtmas4.fsf@wmeyer.eu>

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]


Wilko Meyer <w@wmeyer.eu> writes:

> Thanks for reviewing my patch series!
>
> Christopher Baines <mail@cbaines.net> writes:
>
>> Thanks for sending these patches. I think there's an issue with xsv as
>> one of the inputs (rust-csv-index) doesn't seem to exist.
>
> You're right, I forgot to include rust-csv-index in this patch series,
> but already had it locally, which is why I was able to build xsv without
> noticing it. I'll include a patch to add rust-csv-index in a minute.

I see the new patch now.

The other simple thing I notice is that the commit messages should be in
the present tense (so Add rather than Added). Would you be able to fix
that and then resend the entire series? It's always useful to send all
the patches again when you make changes, as that simplifies the job for
anyone trying to get the latest patches.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2023-10-11 10:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 15:49 [bug#64875] [PATCH 0/4] Adding xsv Wilko Meyer
2023-07-26 15:52 ` [bug#64875] [PATCH 1/4] gnu: Added rust-chan-0.1 Wilko Meyer
2023-07-26 15:52 ` [bug#64875] [PATCH 2/4] gnu: Added rust-filetime-0.1 variant Wilko Meyer
2023-07-26 15:52 ` [bug#64875] [PATCH 3/4] gnu: Added xsv Wilko Meyer
2023-07-26 15:52 ` [bug#64875] [PATCH 4/4] gnu: Added copyright information Wilko Meyer
2023-10-05 10:22 ` [bug#64875] [PATCH 0/4] Adding xsv Christopher Baines
2023-10-05 13:25   ` Wilko Meyer
2023-10-11 10:16     ` Christopher Baines [this message]
2023-10-05 14:04 ` [bug#64875] [PATCH] gnu: Add rust-csv-index Wilko Meyer
2023-10-15 21:57 ` [bug#64875] [PATCH v2 1/5] gnu: Add rust-filetime-0.1 variant Wilko Meyer
2023-10-15 21:57   ` [bug#64875] [PATCH v2 2/5] gnu: Add rust-chan-0.1 Wilko Meyer
2023-10-15 21:57   ` [bug#64875] [PATCH v2 3/5] gnu: Add xsv Wilko Meyer
2023-10-16  9:37     ` bug#64875: " Efraim Flashner
2023-10-15 21:57   ` [bug#64875] [PATCH v2 4/5] gnu: Add rust-csv-index Wilko Meyer
2023-10-15 21:57   ` [bug#64875] [PATCH v2 5/5] gnu: Add copyright header Wilko Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y3dfon2.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=64875@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=w@wmeyer.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).