From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0LPuGcp2JmUDNQEAauVa8A:P1 (envelope-from ) for ; Wed, 11 Oct 2023 12:19:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0LPuGcp2JmUDNQEAauVa8A (envelope-from ) for ; Wed, 11 Oct 2023 12:19:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EAA1F3E8FC for ; Wed, 11 Oct 2023 12:19:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697019594; a=rsa-sha256; cv=none; b=a3A6p1KHqtQFVo503U9UqxbeQyX+5uq08lixZJI8g+Hxes5Zdd7R0sEfkqV2ZdfZrh+qfp LsBbSlhcyLhA+Bqem523oGWnyFddl6DieF2HfZovzNEe5+qXu+fW5uDbYOaQoKT9U+QJiS Q91JiR8YHhtswvk0pRWMcl6vG0vjuV+U0pamSW+zZ/vwIRtfI6uGmwSHnNuXA59mHdSues FtDZoetA9quyGYey4hYrVtP4OSOqkUxrj9Z/k3ksO6+lOPgmMxsX3K/J47kduhcSKU76Pc pMlFPHCPUdH5DcatRTGYRQKy5jUkM12J4zxdlC2P6nnKIjbXEoAEMndLnFxIlA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697019594; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Na1621S+9Oo0otZvgy3HagipTbvbTzVa+jcki8B5Uc0=; b=OSwQx5crINI+iF24unkDYEJ+ZPM1Y52UG2GG37H4nZrLfStBvsrTBf5xYLc0scRVCHFDJ8 JzP5opTPiBg3zStcVu5kF5+q2OiiIbvCSuIkn5Ek7d+D7Ktji+mUjxIslri2s0l8lxphSt yJI1/Yi+9oGkjwbUpToWs0A/Gov3ANrLrN1w8fD9pf1i3XTWyhXo6+5bmMginaXPe7ibTS 5Djc8ormnbzoBD1W0zQIxijDU3DGFFAJbg/dOrYn/QRqHJHw1yh30F3hqPKsEJxjqa6VA8 LAgB/lNS546qzI6xaS9rkb0E0vrS5B/Szq8DSIcFOPFxRGHWmCRpPApkYDT+lg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqWJe-0005Dr-Fx; Wed, 11 Oct 2023 06:19:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqWJY-0005CZ-Gj for guix-patches@gnu.org; Wed, 11 Oct 2023 06:19:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqWJY-0001TL-82 for guix-patches@gnu.org; Wed, 11 Oct 2023 06:19:40 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqWJt-0005Hw-UX for guix-patches@gnu.org; Wed, 11 Oct 2023 06:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64875] [PATCH 0/4] Adding xsv Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Oct 2023 10:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64875 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Wilko Meyer Cc: 64875@debbugs.gnu.org, efraim@flashner.co.il X-Debbugs-Original-Cc: 64875@debbugs.gnu.org, Efraim Flashner , guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169701956020269 (code B ref -1); Wed, 11 Oct 2023 10:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Oct 2023 10:19:20 +0000 Received: from localhost ([127.0.0.1]:37550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqWJE-0005Gr-6Z for submit@debbugs.gnu.org; Wed, 11 Oct 2023 06:19:20 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqWJC-0005Gc-17 for submit@debbugs.gnu.org; Wed, 11 Oct 2023 06:19:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqWIk-0004L8-4b for guix-patches@gnu.org; Wed, 11 Oct 2023 06:18:50 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqWIh-0001HI-TR for guix-patches@gnu.org; Wed, 11 Oct 2023 06:18:49 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id 3716827BBE2; Wed, 11 Oct 2023 11:18:45 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ec0232bb; Wed, 11 Oct 2023 10:18:44 +0000 (UTC) References: <874jj5gyfc.fsf@cbaines.net> <87cyxtmas4.fsf@wmeyer.eu> User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines Date: Wed, 11 Oct 2023 11:16:36 +0100 In-reply-to: <87cyxtmas4.fsf@wmeyer.eu> Message-ID: <875y3dfon2.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -8.16 X-Spam-Score: -8.16 X-Migadu-Queue-Id: EAA1F3E8FC X-TUID: +qOdsr3Bzzgg --=-=-= Content-Type: text/plain Wilko Meyer writes: > Thanks for reviewing my patch series! > > Christopher Baines writes: > >> Thanks for sending these patches. I think there's an issue with xsv as >> one of the inputs (rust-csv-index) doesn't seem to exist. > > You're right, I forgot to include rust-csv-index in this patch series, > but already had it locally, which is why I was able to build xsv without > noticing it. I'll include a patch to add rust-csv-index in a minute. I see the new patch now. The other simple thing I notice is that the commit messages should be in the present tense (so Add rather than Added). Would you be able to fix that and then resend the entire series? It's always useful to send all the patches again when you make changes, as that simplifies the job for anyone trying to get the latest patches. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmUmdoFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcB5A/+PkL56aKZ+tJat1R352+Ag8s6dwlp+u85 CE4S/nVe4EbMOBJ9TwQHwc9tZqAUAZpkYs3C0gnzF2fVGBhMWt1PgpxcA1t8pDxu yv7gbry+efQUJm+Z5HcPE0eXeF7qgeWUtQhO1x166S4/6UceavmmluuR8qBNmiqC +55sdfvFlo4Ejx4922CLJEcnAdihc0W79d6XI8Dw/kj5gN/x7SMKPrX33ovfrMoW 75hiMAj56LVHNq5ra5jNyIZfMVmiSH30boFXTJJk7cPTMxzYMF7xRe2gti+8s5Ja sdabLMnxifAurJb7EFAWc07EMTVRxJPD8dCYuCeX/BwGOV/2vBUT45FJIlVxpskC BteWeUIwm8sOO8n1zKZlhIPwcFxGyTKMnAeR/aDTdMNwh9W9ZkMX8HQtOtUi+3Ul ZaZbZdFV0UNd+HPE86sMmloOCxomckl8wQtP2QrV24tBN2SUmfuqVL83CZ481nj4 69EfE4X1lnMT94EK11azwPRjeyyZhqrMr0QtDfUfY1L3pJuKj3gDGoq2FzqG0EG1 hXq84tSny88OaLHFkEhncd6kKUKtndxi5zEYqnQCMUV6+xopiJo+r8j9OSjf6RbZ b5/JhXaz/ZvO1wkLnJH2vrYywMr8KodsRxR0fBFhyL5AQGnoHfwdkLtNGswO2gID +r/MG3cae8w= =vOab -----END PGP SIGNATURE----- --=-=-=--