unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp.
@ 2017-10-14  8:55 Oleg Pykhalov
  2017-10-15 20:27 ` Christopher Baines
  0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2017-10-14  8:55 UTC (permalink / raw)
  To: 28829

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH] gnu: Add emacs-company-quickhelp. --]
[-- Type: text/x-patch, Size: 1685 bytes --]

From 3b82989997d7bf06fcdc07043a83aa7369dc82af Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 14 Oct 2017 11:53:59 +0300
Subject: [PATCH] gnu: Add emacs-company-quickhelp.

* gnu/packages/emacs.scm (emacs-company-quickhelp): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 66f0a2ebe..b85c16044 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2352,6 +2352,30 @@ front-ends.  Company comes with many back-ends, e.g. @code{company-elisp}.
 These are distributed in separate files and can be used individually.")
     (license license:gpl3+)))
 
+(define-public emacs-company-quickhelp
+  (package
+    (name "emacs-company-quickhelp")
+    (version "2.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/expez/company-quickhelp/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0xrn2z1dgk5gmkmp2jkn9g83ckk39lqp5pyyv8rl7f6gqvib3qh0"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-pos-tip" ,emacs-pos-tip)
+       ("emacs-company" ,emacs-company)))
+    (home-page "https://github.com/expez/company-quickhelp")
+    (synopsis "Popup documentation for completion candidates")
+    (description "@code{company-quickhelp} shows a documentation for the
+completion candidate.")
+    (license license:gpl3+)))
+
 (define-public emacs-multiple-cursors
   (package
     (name "emacs-multiple-cursors")
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp.
  2017-10-14  8:55 [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp Oleg Pykhalov
@ 2017-10-15 20:27 ` Christopher Baines
  2017-10-16 10:15   ` Oleg Pykhalov
  0 siblings, 1 reply; 5+ messages in thread
From: Christopher Baines @ 2017-10-15 20:27 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 28829

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Sat, 14 Oct 2017 11:55:19 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:

> +    (synopsis "Popup documentation for completion candidates")
> +    (description "@code{company-quickhelp} shows a documentation for the
> +completion candidate.")

How about "@code{company-quickhelp} shows documentation for the
completion candidate when using the Company text completion framework." for the description?

I've removed the "a", as "shows documentation" sounds better to me, and
also tried to mention some relation to Company to put this package in
context.

What do you think?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp.
  2017-10-15 20:27 ` Christopher Baines
@ 2017-10-16 10:15   ` Oleg Pykhalov
  2017-10-31  8:05     ` Christopher Baines
  0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2017-10-16 10:15 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 28829

Hello Christopher,

Christopher Baines <mail@cbaines.net> writes:

>> +    (synopsis "Popup documentation for completion candidates")
>> +    (description "@code{company-quickhelp} shows a documentation for the
>> +completion candidate.")
>
> How about "@code{company-quickhelp} shows documentation for the
> completion candidate when using the Company text completion
> framework." for the description?
>
> I've removed the "a", as "shows documentation" sounds better to me, and
> also tried to mention some relation to Company to put this package in
> context.
>
> What do you think?

Great!  Totally agree with you.

Thanks,
Oleg.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp.
  2017-10-16 10:15   ` Oleg Pykhalov
@ 2017-10-31  8:05     ` Christopher Baines
  2017-10-31 12:05       ` Oleg Pykhalov
  0 siblings, 1 reply; 5+ messages in thread
From: Christopher Baines @ 2017-10-31  8:05 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 28829

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Mon, 16 Oct 2017 13:15:58 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:

> Hello Christopher,
> 
> Christopher Baines <mail@cbaines.net> writes:
> 
> >> +    (synopsis "Popup documentation for completion candidates")
> >> +    (description "@code{company-quickhelp} shows a documentation for the
> >> +completion candidate.")  
> >
> > How about "@code{company-quickhelp} shows documentation for the
> > completion candidate when using the Company text completion
> > framework." for the description?
> >
> > I've removed the "a", as "shows documentation" sounds better to me, and
> > also tried to mention some relation to Company to put this package in
> > context.
> >
> > What do you think?  
> 
> Great!  Totally agree with you.

Ok, apologies for the late reply, I had a very busy couple of weeks,
and would have liked to reply sooner.

I see that you're now setup to push this yourself, so I'll leave it to
you to push :D

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp.
  2017-10-31  8:05     ` Christopher Baines
@ 2017-10-31 12:05       ` Oleg Pykhalov
  0 siblings, 0 replies; 5+ messages in thread
From: Oleg Pykhalov @ 2017-10-31 12:05 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 28829, 28829-done

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

Hello Christopher,

Christopher Baines <mail@cbaines.net> writes:

>> >> +    (synopsis "Popup documentation for completion candidates")
>> >> +    (description "@code{company-quickhelp} shows a documentation for the
>> >> +completion candidate.")  
>> >
>> > How about "@code{company-quickhelp} shows documentation for the
>> > completion candidate when using the Company text completion
>> > framework." for the description?
>> >
>> > I've removed the "a", as "shows documentation" sounds better to me, and
>> > also tried to mention some relation to Company to put this package in
>> > context.
>> >
>> > What do you think?  
>> 
>> Great!  Totally agree with you.
>
> Ok, apologies for the late reply, I had a very busy couple of weeks,
> and would have liked to reply sooner.
>
> I see that you're now setup to push this yourself, so I'll leave it to
> you to push :D

OK.

Pushed as 016590a951b901790d558b59cf74bf4ccd1621a5

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-10-31 12:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-14  8:55 [bug#28829] [PATCH] gnu: Add emacs-company-quickhelp Oleg Pykhalov
2017-10-15 20:27 ` Christopher Baines
2017-10-16 10:15   ` Oleg Pykhalov
2017-10-31  8:05     ` Christopher Baines
2017-10-31 12:05       ` Oleg Pykhalov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).