unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#32613] [PATCH] gnu: Add emacs-picpocket.
@ 2018-09-02 18:34 Alex Vong
  2018-09-04 13:39 ` bug#32613: " Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Vong @ 2018-09-02 18:34 UTC (permalink / raw)
  To: 32613; +Cc: alexvong1995


[-- Attachment #1.1: Type: text/plain, Size: 175 bytes --]

Hello guix,

This patch adds picpocket, which is an emacs package for displaying
pictures. It supports full-screen and rotation, which is better than the
vanilla image-mode.


[-- Attachment #1.2: 0001-gnu-Add-emacs-picpocket.patch --]
[-- Type: text/x-diff, Size: 2921 bytes --]

From c126ff68c5f881d506226e2a260b96fa6d4635ea Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Mon, 3 Sep 2018 02:25:31 +0800
Subject: [PATCH] gnu: Add emacs-picpocket.

* gnu/packages/emacs.scm (emacs-picpocket): New public variable.
---
 gnu/packages/emacs.scm | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 08554280c..a3c695975 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -15,7 +15,7 @@
 ;;; Copyright © 2016, 2017 Nils Gillmann <ng0@n0.is>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2016, 2017, 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
-;;; Copyright © 2016, 2017 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2016, 2017, 2018 Alex Vong <alexvong1995@gmail.com>
 ;;; Copyright © 2016, 2017, 2018 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2017 Christopher Baines <mail@cbaines.net>
 ;;; Copyright © 2017, 2018 Mathieu Othacehe <m.othacehe@gmail.com>
@@ -11314,6 +11314,44 @@ e.g. the package dependencies it requires.  See function
 file.")
       (license license:gpl3+))))
 
+(define-public emacs-picpocket
+  (let ((version "20180610.1059") ; taken from melpa
+        (commit "ce4b6ed088384f2414af82e8e4eae5b92c2874bf"))
+    (package
+      (name "emacs-picpocket")
+      (version version)
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/johanclaesson/picpocket")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "15vpbcv83mc4j1pvrk7xic0klh2bl9gzg2xxs7c2lmnix52hy8mv"))))
+      (build-system emacs-build-system)
+      (arguments ; needed for running tests
+       `(#:tests? #t
+         #:emacs ,emacs
+         #:test-command '("emacs" "--batch"
+                          "-l" "picpocket-test.el"
+                          "-f" "ert-run-tests-batch-and-exit")))
+      (home-page "https://github.com/johanclaesson/picpocket")
+      (synopsis "Image viewer for Emacs")
+      (description
+       "Picpocket is an image viewer which requires GNU Emacs 24.4+
+compiled with ImageMagick.  It have commands for:
+
+@itemize
+@item File operations on the picture files (delete, move, copy, hardlink).
+@item Scale and rotate the picture.
+@item Associate pictures with tags which are saved to disk.
+@item Filter pictures according to tags.
+@item Customizing keystrokes for quick tagging and file operations.
+@item Undo and browse history of undoable commands.
+@end itemize")
+      (license license:gpl3+))))
+
 (define-public emacs-wgrep-helm
   ;; `emacs-wgrep-helm' was mistakenly added.
   (deprecated-package "emacs-wgrep-helm" emacs-wgrep))
-- 
2.18.0


[-- Attachment #1.3: Type: text/plain, Size: 14 bytes --]


Cheers,
Alex

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#32613: [PATCH] gnu: Add emacs-picpocket.
  2018-09-02 18:34 [bug#32613] [PATCH] gnu: Add emacs-picpocket Alex Vong
@ 2018-09-04 13:39 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-09-04 13:39 UTC (permalink / raw)
  To: Alex Vong; +Cc: 32613-done

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi Alex,

Alex Vong <alexvong1995@gmail.com> skribis:

> From c126ff68c5f881d506226e2a260b96fa6d4635ea Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Mon, 3 Sep 2018 02:25:31 +0800
> Subject: [PATCH] gnu: Add emacs-picpocket.
>
> * gnu/packages/emacs.scm (emacs-picpocket): New public variable.

Applied with the minor changes below.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 595 bytes --]

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2bacd560f..957b72f4e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -11340,8 +11340,7 @@ file.")
       (home-page "https://github.com/johanclaesson/picpocket")
       (synopsis "Image viewer for Emacs")
       (description
-       "Picpocket is an image viewer which requires GNU Emacs 24.4+
-compiled with ImageMagick.  It have commands for:
+       "Picpocket is an image viewer for GNU Emacs.  It has commands for:
 
 @itemize
 @item File operations on the picture files (delete, move, copy, hardlink).

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-04 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-02 18:34 [bug#32613] [PATCH] gnu: Add emacs-picpocket Alex Vong
2018-09-04 13:39 ` bug#32613: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).