unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Julien Lepiller <julien@lepiller.eu>,
	Tobias Geerinckx-Rice <me@tobias.gr>,
	41259@debbugs.gnu.org
Subject: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount @storedir@ read-only.
Date: Thu, 14 May 2020 16:13:50 +0200	[thread overview]
Message-ID: <874ksivc2p.fsf@devup.no> (raw)
In-Reply-To: <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

Julien Lepiller <julien@lepiller.eu> writes:

>>+etc/%.mount: etc/%.mount.in	\
>>+			 $(top_builddir)/config.status
>>+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
>>+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
>>+	       "$<" > "$@.tmp";		\
>>+	mv "$@.tmp" "$@"
>> 
>> etc/guix-%.service: etc/guix-%.service.in	\
>> 			 $(top_builddir)/config.status
>
> I see that's how it's done with the existing service, but why sed the .in file when we could let configure.ac take care of it?

Because --storedir can in theory be something like '$prefix/store',
which would not get properly expanded by configure.  See "Installation
Directory Variables" in the GNU Autoconf manual:

  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Installation-Directory-Variables.html

(in particular scroll down to the notice about AC_CONFIG_FILES)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-05-14 14:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 13:48 [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount @storedir@ read-only Tobias Geerinckx-Rice via Guix-patches via
2020-05-14 14:01 ` Julien Lepiller
2020-05-14 14:13   ` Marius Bakke [this message]
2020-05-14 14:25     ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-14 14:21   ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-14 16:35   ` Julien Lepiller
2020-05-14 18:49     ` Julien Lepiller
2020-05-14 14:24 ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-15  7:34 ` Vincent Legoll
2020-05-15 16:25 ` [bug#41259] .gitignore ? Vincent Legoll
2020-05-15 16:52   ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-15 16:55     ` Vincent Legoll
2020-05-16 12:38       ` Vincent Legoll
2020-05-16 14:04         ` Tobias Geerinckx-Rice via Guix-patches via
2021-08-03 19:56           ` bug#41259: [PATCH] etc: Add a systemd unit to bind-mount @storedir@ read-only Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ksivc2p.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=41259@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).