From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qLqDAEZUvV4HUgAA0tVLHw (envelope-from ) for ; Thu, 14 May 2020 14:23:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QJReNkVUvV4oNwAA1q6Kng (envelope-from ) for ; Thu, 14 May 2020 14:23:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF0A694050F for ; Thu, 14 May 2020 14:23:00 +0000 (UTC) Received: from localhost ([::1]:44026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZElH-0004bK-Ls for larch@yhetil.org; Thu, 14 May 2020 10:22:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZEdb-0000VK-ES for guix-patches@gnu.org; Thu, 14 May 2020 10:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZEdb-0003uk-3h for guix-patches@gnu.org; Thu, 14 May 2020 10:15:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZEda-0004y3-W7 for guix-patches@gnu.org; Thu, 14 May 2020 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount @storedir@ read-only. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 May 2020 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41259 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller , Tobias Geerinckx-Rice , 41259@debbugs.gnu.org Received: via spool by 41259-submit@debbugs.gnu.org id=B41259.158946565118991 (code B ref 41259); Thu, 14 May 2020 14:15:02 +0000 Received: (at 41259) by debbugs.gnu.org; 14 May 2020 14:14:11 +0000 Received: from localhost ([127.0.0.1]:34289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZEcg-0004w9-Aj for submit@debbugs.gnu.org; Thu, 14 May 2020 10:14:11 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZEca-0004vC-2p for 41259@debbugs.gnu.org; Thu, 14 May 2020 10:14:03 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A84475C0046; Thu, 14 May 2020 10:13:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 14 May 2020 10:13:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=5fcAH9tulVXXHJmsWCJp/2N/Ya ZU+yDkHFdUof3rcIQ=; b=j9wRzGopguSbuNeej7jQ1p1j8RY6mzm8nw9k97RMTQ PuPxHOtBJtiUrPi3BxkUlgKT5Gnr2uPJniHSDX9sLjG+lyR2Wh4q3GPE7FgjaFPj CkvwVrmZPeGbuueNx946k9UINH5CeEjgJc0yC6MoeVlK5D9GOHD5FAy1PBu3CGel RxU3Nb6oLWyL+DpwuhoI11SWK4LpxVu16AHSG+VDK9VCc5LWSk3bTgGuTBBEQN+G 5/G1OQM5477YP88p1dbw4IYzT++XXoKb50zuLmaFo/cAkJu6OEBteI2cv2S6ydGI oBvO2yeHP6kN3GED5twaO6anFkVwsWp8iU1gY9FvL/YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5fcAH9 tulVXXHJmsWCJp/2N/YaZU+yDkHFdUof3rcIQ=; b=WqkFXf2eV5SIU1Vp43Xndj GR3gLHqd0IwE0dEoyLV7+NKDcuX8hsebgsbeQwbEnjx67MnByZh1xT2BmPPI0Iz8 JJ/WOMkZPEt27y5dTRmevXmLwuma2f6gnUwF3B+tCoFDTxH5s8WXlMj9LH41boQ0 X99PZuvVQlPYQk1pqA9hR/ImhooDBIyUAxVRow4noRdZ9HJFFJ4KaaITcW8u7HbZ daegWr7vo/6T2ah1+eRL6yMz4Npd5MYIo+9yiP5xEDIcUtnVMo6QnWpbbSXt5ElE 7XtTbqHJw8y84ZiiUGXwzneCSZznzlzVBaTaYhoXZxND31oQaPTiJOxFnq8bgv6w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleeigdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhiuhhs uceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuggftrfgrth htvghrnhepkedugeeiledvvdegieelffejudeitdfggfeiieffheduhffgvefhueeigffh heeknecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeekgedrvddtvddrieekrdejhe enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggr khhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id AF4A13060EF5; Thu, 14 May 2020 10:13:52 -0400 (EDT) From: Marius Bakke In-Reply-To: References: <20200514134846.29037-1-me@tobias.gr> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 14 May 2020 16:13:50 +0200 Message-ID: <874ksivc2p.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=fastmail.com header.s=fm2 header.b=j9wRzGop; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=WqkFXf2e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.99 X-Spamd-Result: default: False [1.99 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53826232794354]; MX_INVALID(1.00)[cached]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[fastmail.com]; R_MISSING_CHARSET(2.50)[]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.05), country: US(-0.00), ip: 209.51.188.17(-0.54)]; R_DKIM_REJECT(1.00)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; DKIM_TRACE(0.00)[fastmail.com:-,messagingengine.com:-]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:url,lepiller.eu:email,configure.ac:url]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; SPF_REPUTATION_HAM(0.00)[-0.56483251278136]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[fastmail.com : SPF not aligned (relaxed),none] X-Scanner: scn0 X-TUID: Ighjk1g18dkH --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Julien Lepiller writes: >>+etc/%.mount: etc/%.mount.in \ >>+ $(top_builddir)/config.status >>+ $(AM_V_GEN)$(MKDIR_P) "`dirname $@`"; \ >>+ $(SED) -e 's|@''storedir''@|$(storedir)|' < \ >>+ "$<" > "$@.tmp"; \ >>+ mv "$@.tmp" "$@" >>=20 >> etc/guix-%.service: etc/guix-%.service.in \ >> $(top_builddir)/config.status > > I see that's how it's done with the existing service, but why sed the .in= file when we could let configure.ac take care of it? Because --storedir can in theory be something like '$prefix/store', which would not get properly expanded by configure. See "Installation Directory Variables" in the GNU Autoconf manual: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/= html_node/Installation-Directory-Variables.html (in particular scroll down to the notice about AC_CONFIG_FILES) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl69Uh4ACgkQoqBt8qM6 VPociQf9EQ1BTKTs33f/6L5L3OoHTTGwOSxg5gzbx0PtceI9968Cr1wcYn/z7AD5 TEam6RJnwcwoZiSiXyXS5+ls/52fxjh86vAjFRV6ghULbCZeolSPVnnU9ZaMtWAx MZhOzeYWecQUWdj0GZRWuTNUQ9ffxxPrRAvqa7eClbrELEpSu3dj6VrtBkzSVa3/ RDNQGYrrUrHshQHwr2/P1Io9UfGctQZ8eTl0wmUM7Vt4AAVQav+JNyGQ4b1DLtRK IteWbLPmeYo2fT+MH5OwYtnWoQnOQnk+Y7u3NJO3XuiV3WSWidYG5diAEcYGPNlf KAroIxiMqLMJ+1JJOSGuPtifufoBOQ== =7zsJ -----END PGP SIGNATURE----- --=-=-=--