unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#43185] [PATCH 0/1] gnu: emacs-auctex: Configure executable paths.
@ 2020-09-03 17:23 Arun Isaac
  2020-09-03 17:36 ` [bug#43185] [PATCH] " Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2020-09-03 17:23 UTC (permalink / raw)
  To: 43185; +Cc: Arun Isaac

This patch configures variables in emacs-auctex to use absolute store paths to
ghostscript and texlive commands. This means we have to add ghostscript to the
inputs. This, of course, greatly increases the closure size of
emacs-auctex. But, ghostscript is required for auctex to generate in buffer
previews. Generating in buffer previews is an important feature of auctex and
users would expect that to work out of the box without having to manually
install ghostscript into their profile.

Arun Isaac (1):
  gnu: emacs-auctex: Configure executable paths.

 gnu/packages/emacs-xyz.scm | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

-- 
2.28.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#43185] [PATCH] gnu: emacs-auctex: Configure executable paths.
  2020-09-03 17:23 [bug#43185] [PATCH 0/1] gnu: emacs-auctex: Configure executable paths Arun Isaac
@ 2020-09-03 17:36 ` Arun Isaac
  2020-09-04  9:57   ` Mathieu Othacehe
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2020-09-03 17:36 UTC (permalink / raw)
  To: 43185; +Cc: Arun Isaac

* gnu/packages/emacs-xyz.scm (emacs-auctex): Configure absolute paths to
ghostscript and texlive executables.
[inputs]: Add ghostscript.
---
 gnu/packages/emacs-xyz.scm | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3482686ccd..e5d748b611 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -175,6 +175,7 @@
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages shells)
   #:use-module (gnu packages sqlite)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages video)
   #:use-module (gnu packages haskell-xyz)
@@ -1914,6 +1915,21 @@ as a library for other Emacs packages.")
        #:exclude '("^tests/" "^latex/README")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'configure
+           (lambda* (#:key inputs #:allow-other-keys)
+             (emacs-substitute-variables "preview.el"
+               ("preview-gs-command"
+                (string-append (assoc-ref inputs "ghostscript") "/bin/gs")))
+             (substitute* "preview.el"
+               (("\"dvipng ")
+                (string-append "\"" (assoc-ref inputs "texlive")
+                               "/bin/dvipng "))
+               (("\"dvips ")
+                (string-append "\"" (assoc-ref inputs "texlive")
+                               "/bin/dvips "))
+               (("\"pdf2dsc ")
+                (string-append "\"" (assoc-ref inputs "ghostscript")
+                               "/bin/pdf2dsc ")))))
          (add-after 'install 'install-doc
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
@@ -1928,7 +1944,8 @@ as a library for other Emacs packages.")
     (native-inputs
      `(("perl" ,perl)))
     (inputs
-     `(("texlive" ,(texlive-union (list texlive-amsfonts)))))
+     `(("ghostscript" ,ghostscript)
+       ("texlive" ,(texlive-union (list texlive-amsfonts)))))
     (home-page "https://www.gnu.org/software/auctex/")
     (synopsis "Integrated environment for TeX")
     (description
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#43185] [PATCH] gnu: emacs-auctex: Configure executable paths.
  2020-09-03 17:36 ` [bug#43185] [PATCH] " Arun Isaac
@ 2020-09-04  9:57   ` Mathieu Othacehe
  2020-09-04 11:01     ` bug#43185: " Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Othacehe @ 2020-09-04  9:57 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 43185


Hello Arun,

> * gnu/packages/emacs-xyz.scm (emacs-auctex): Configure absolute paths to
> ghostscript and texlive executables.
> [inputs]: Add ghostscript.

This looks fine to me.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#43185: [PATCH] gnu: emacs-auctex: Configure executable paths.
  2020-09-04  9:57   ` Mathieu Othacehe
@ 2020-09-04 11:01     ` Arun Isaac
  0 siblings, 0 replies; 4+ messages in thread
From: Arun Isaac @ 2020-09-04 11:01 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 43185-done


Pushed to master, thanks for the review!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-04 11:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 17:23 [bug#43185] [PATCH 0/1] gnu: emacs-auctex: Configure executable paths Arun Isaac
2020-09-03 17:36 ` [bug#43185] [PATCH] " Arun Isaac
2020-09-04  9:57   ` Mathieu Othacehe
2020-09-04 11:01     ` bug#43185: " Arun Isaac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).