unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 42634@debbugs.gnu.org
Subject: [bug#42634] [PATCH 3/3] scripts: system: Add support for image-type.
Date: Thu, 24 Sep 2020 17:39:33 +0200	[thread overview]
Message-ID: <874knn6v62.fsf@gnu.org> (raw)
In-Reply-To: <20200731144929.703345-3-othacehe@gnu.org> (Mathieu Othacehe's message of "Fri, 31 Jul 2020 16:49:29 +0200")

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * guix/scripts/system.scm (list-image-types): New procedure,
> (%options): add "image-type" and "list-image-types" options, remove
> "file-system-type" option,
> (show-help): adapt accordingly,
> (%default-options): also adapt, and set the default "image-type" to "raw",
> (perform-action): add image-type argument and remove file-system-type argument,
> (process-action):  adapt perform-action call,
> (system-derivation-for-action): remove base-image
> argument, add image-type argument, and use it to create the image passed to
> "system-image".

LGTM (with corresponding doc)!

Perhaps you can also add a ‘guix system list-image-types’ command to
tests/guix-system.sh for good measure.  That’d at least catch broken
modules and similar.

Thanks,
Ludo’.




  reply	other threads:[~2020-09-24 16:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 14:48 [bug#42634] [PATCH 0/3] Add image-type support Mathieu Othacehe
2020-07-31 14:49 ` [bug#42634] [PATCH 1/3] image: " Mathieu Othacehe
2020-07-31 14:49   ` [bug#42634] [PATCH 2/3] system: " Mathieu Othacehe
2020-09-24 15:37     ` Ludovic Courtès
2020-07-31 14:49   ` [bug#42634] [PATCH 3/3] scripts: system: Add support for image-type Mathieu Othacehe
2020-09-24 15:39     ` Ludovic Courtès [this message]
2020-09-30  9:51       ` bug#42634: " Mathieu Othacehe
2020-09-24 15:35   ` [bug#42634] [PATCH 1/3] image: Add image-type support Ludovic Courtès
2020-09-24 15:34 ` [bug#42634] [PATCH 0/3] " Ludovic Courtès
2020-09-30  9:50   ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874knn6v62.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=42634@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).