From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SLACMlPGbF9/YQAA0tVLHw (envelope-from ) for ; Thu, 24 Sep 2020 16:16:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8LzALVPGbF/kLQAAbx9fmQ (envelope-from ) for ; Thu, 24 Sep 2020 16:16:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40F299403D6 for ; Thu, 24 Sep 2020 16:16:19 +0000 (UTC) Received: from localhost ([::1]:59608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLTur-00031W-I8 for larch@yhetil.org; Thu, 24 Sep 2020 12:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLTLm-0000Jl-Hj for guix-patches@gnu.org; Thu, 24 Sep 2020 11:40:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLTLm-0007XP-7v for guix-patches@gnu.org; Thu, 24 Sep 2020 11:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLTLm-0008De-3G for guix-patches@gnu.org; Thu, 24 Sep 2020 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42634] [PATCH 3/3] scripts: system: Add support for image-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Sep 2020 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42634 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: Mathieu Othacehe , 42634@debbugs.gnu.org Received: via spool by 42634-submit@debbugs.gnu.org id=B42634.160096198631568 (code B ref 42634); Thu, 24 Sep 2020 15:40:02 +0000 Received: (at 42634) by debbugs.gnu.org; 24 Sep 2020 15:39:46 +0000 Received: from localhost ([127.0.0.1]:41382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLTLW-0008D5-2I for submit@debbugs.gnu.org; Thu, 24 Sep 2020 11:39:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLTLT-0008Ct-QO for 42634@debbugs.gnu.org; Thu, 24 Sep 2020 11:39:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35086) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLTLO-0007Ts-Hl; Thu, 24 Sep 2020 11:39:38 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57566 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLTLK-0000Cl-Qc; Thu, 24 Sep 2020 11:39:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200731144929.703345-1-othacehe@gnu.org> <20200731144929.703345-3-othacehe@gnu.org> Date: Thu, 24 Sep 2020 17:39:33 +0200 In-Reply-To: <20200731144929.703345-3-othacehe@gnu.org> (Mathieu Othacehe's message of "Fri, 31 Jul 2020 16:49:29 +0200") Message-ID: <874knn6v62.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: aMDZL/73koOt Mathieu Othacehe skribis: > * guix/scripts/system.scm (list-image-types): New procedure, > (%options): add "image-type" and "list-image-types" options, remove > "file-system-type" option, > (show-help): adapt accordingly, > (%default-options): also adapt, and set the default "image-type" to "raw", > (perform-action): add image-type argument and remove file-system-type arg= ument, > (process-action): adapt perform-action call, > (system-derivation-for-action): remove base-image > argument, add image-type argument, and use it to create the image passed = to > "system-image". LGTM (with corresponding doc)! Perhaps you can also add a =E2=80=98guix system list-image-types=E2=80=99 c= ommand to tests/guix-system.sh for good measure. That=E2=80=99d at least catch broken modules and similar. Thanks, Ludo=E2=80=99.