From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 47434@debbugs.gnu.org, "Néfix Estrada" <nefixestrada@gmail.com>
Subject: [bug#47434] [PATCH] Added Go 1.16.2
Date: Sun, 28 Mar 2021 20:46:49 -0400 [thread overview]
Message-ID: <874kgudbwm.fsf_-_@gmail.com> (raw)
In-Reply-To: <cf91e6e3120d04769ee9b890f6f9a6fecaf057c9.camel@telenet.be> (Maxime Devos's message of "Sat, 27 Mar 2021 20:56:06 +0100")
Hi,
Maxime Devos <maximedevos@telenet.be> writes:
> On Sat, 2021-03-27 at 17:29 +0100, Néfix Estrada wrote:
>> Signed-off-by: Néfix Estrada <nefixestrada@gmail.com>
>> ---
>> gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>
> A commit message is missing, see ‘16.6 Submitting Patches’ in
> the manual (and there are plenty of examples in "git log").
>
> There have been a few patches lately by new
> contributers without commit messages; is this section of the
> manual hard to find? Is there some location where we could
> prominently feature a link to the section?
>
> Also, ‘we’ don't use ‘Signed-off-by’ like that. From ‘16.8 Commit Access’:
>
> When pushing a commit on behalf of somebody else, please add a
> ‘Signed-off-by’ line at the end of the commit log message—e.g., with
> ‘git am --signoff’. This improves tracking of who did what.
>
> Thus, it is up to committers to add a line like that. Perhaps a system
> like the Linux kernel project uses could be useful in the future,
> but I don't think ‘we’ are at that point yet
>
>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
>> index d9988cd7ad..df17955c93 100644
>> --- a/gnu/packages/golang.scm
>> +++ b/gnu/packages/golang.scm
>> @@ -25,6 +25,7 @@
>> ;;; Copyright © 2020 Martin Becze <mjbecze@riseup.net>
>> ;;; Copyright © 2021 Ricardo Wurmus <rekado@elephly.net>
>> ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
>> +;;; Copyright © 2021 Néfix Estrada <nefixestrada@gmail.com>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -440,6 +441,32 @@ in the style of communicating sequential processes (@dfn{CSP}).")
>> ,@(package-native-inputs go-1.4)))
>> (supported-systems %supported-systems)))
>>
>> +(define-public go-1.16
>> + (package
>> + (inherit go-1.14)
>> + [...]
>
>> + (arguments
>> + (substitute-keyword-arguments (package-arguments go-1.14)
>> + ((#:phases phases)
>> + `(modify-phases ,phases
>
> This part looks good to me.
>
>> + (add-after 'prebuild 'prebuild-1-16
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")))
>> + (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt"
>> + (("\\[\\!cgo\\] skip")
>> + "[!exec:cc] skip")))))))))))
>> +
>
> What's this 'prebuild-1-16' phase for? Please add a comment explaining!
> And what's (let* ((gcclib ...) ...) doing there if gcclib isn't used afterwards?
>
>> (define-public go go-1.14)
>
> Something to consider for people who know the go situation in guix:
> could this be replaced with (define-public go go-1.16) after this patch?
> (And go-1.14 deleted as there are no uses of it anymore.)
> The output of "guix refresh --list-dependent go" is:
>
> Building the following 125 packages would ensure 440 dependent packages are rebuilt:
> [...]
>
> so this shouldn't cause a world-rebuild (note go packages are (reportedly)
> cheap to build). But perhaps there are API incompatibilities between 1.16 and
> 1.14? idk.
Go 1.16 does break some go packages. I have a similar patch locally but
I haven't pushed it yet because I was pursuing the different failures it
causes.
Maxim
next prev parent reply other threads:[~2021-03-29 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 16:29 [bug#47434] [PATCH] Added Go 1.16.2 Néfix Estrada
2021-03-27 19:56 ` Maxime Devos
2021-03-29 0:46 ` Maxim Cournoyer [this message]
2021-03-29 6:18 ` Maxime Devos
2021-08-05 22:50 ` bug#47434: " Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kgudbwm.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=47434@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=nefixestrada@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).