From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IKyPK8wjYWCCzAAAgWs5BA (envelope-from ) for ; Mon, 29 Mar 2021 02:48:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GCd9JcwjYWCjKAAAbx9fmQ (envelope-from ) for ; Mon, 29 Mar 2021 00:48:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1939017CA8 for ; Mon, 29 Mar 2021 02:48:12 +0200 (CEST) Received: from localhost ([::1]:50872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQg4h-0002o2-8J for larch@yhetil.org; Sun, 28 Mar 2021 20:48:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQg4Y-0002nv-4f for guix-patches@gnu.org; Sun, 28 Mar 2021 20:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQg4X-0005rZ-TN for guix-patches@gnu.org; Sun, 28 Mar 2021 20:48:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQg4X-0002Mg-RV for guix-patches@gnu.org; Sun, 28 Mar 2021 20:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47434] [PATCH] Added Go 1.16.2 Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Mar 2021 00:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47434 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 47434@debbugs.gnu.org, =?UTF-8?Q?N=C3=A9fix?= Estrada Received: via spool by 47434-submit@debbugs.gnu.org id=B47434.16169788249014 (code B ref 47434); Mon, 29 Mar 2021 00:48:01 +0000 Received: (at 47434) by debbugs.gnu.org; 29 Mar 2021 00:47:04 +0000 Received: from localhost ([127.0.0.1]:47312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQg3b-0002LK-PF for submit@debbugs.gnu.org; Sun, 28 Mar 2021 20:47:04 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:43749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQg3Z-0002Kq-PG for 47434@debbugs.gnu.org; Sun, 28 Mar 2021 20:47:02 -0400 Received: by mail-qt1-f169.google.com with SMTP id s2so8256367qtx.10 for <47434@debbugs.gnu.org>; Sun, 28 Mar 2021 17:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uXVqh2PmQRMpKOYTkcJGsoU9LEqct4mPkn0mtlSF89Q=; b=RWmLP6SbCIoOCljuHwn112K0pSNo3/RC6h2IObHkPD/Ergc+ekwuR0Q+nWtoY/Amr+ P9dyctwexQ4SOYgBaU4u+owCMKrkz2xFMA999vFInY7esSgHb7WcT1hrloeuI3iJ0G3O 7qWi8VkIAeCASMOb1vHShb+B/H71mmHUHkJty4oRaWYgNJm+uLT2FxvkDpmFrZgCL3yw Zuvky2MRgmyQO49DsfLi7QsDJ8Hf1yvLRLVFMLECM38sfYq5/VwZuqgTfkhftVPo9SGH cmEpkCK1nMcFbUvLJzLslmqW4lmkkew/9KkKMwMhblZT2ZB2Vs2nm71Inkc55rosHpYB cyOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uXVqh2PmQRMpKOYTkcJGsoU9LEqct4mPkn0mtlSF89Q=; b=qT4nmVygk3FaIVXO4DAX02zkc6+0KWtMO85mySB8rWiU5ubiAdedtRgENCBmEv7mK+ oUO11qtt7cJN0rE2LcaODqhA1fKtC0r/5Ilw9ohJ3+Pw2cMc6ic4ogrC6dxK/cgEVwzC fsECxsNSiiqVtAzUixS0EPXfz/xLuy4YUfF+ouVHwnkRkuknwTvQbWACLbopgae6xGLa K07oVKW5OLrXiCI9UeTUrjhRUy64bsv9iSNu1MVc2oTCAlt56sUu/KXM/mwuwu4mrvJR RyDOzJiY6byX04DdS/6Vj+MwuETHq0UpcA6BWv1nrK4849gRQ30GQYP/z7gTDJS1c4XG JicA== X-Gm-Message-State: AOAM533+3y3fz4tfLc9Fk6reiCyLRLID4JAgrwhtBeZLyOPgCfTb4eXG dSaaLh6pYGobXqslf6KGhrvcLrvg4mY= X-Google-Smtp-Source: ABdhPJwJHYkxKlaiOvXRCOWRBrx7CuKtERc1mOW4Wd3xzcQT+dMehox5kws4c8UI4IufjvHTnaGm3w== X-Received: by 2002:a05:622a:188:: with SMTP id s8mr20742852qtw.42.1616978815805; Sun, 28 Mar 2021 17:46:55 -0700 (PDT) Received: from hurd (dsl-155-113.b2b2c.ca. [66.158.155.113]) by smtp.gmail.com with ESMTPSA id a138sm12139150qkg.29.2021.03.28.17.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 17:46:55 -0700 (PDT) From: Maxim Cournoyer References: <20210327162953.32278-1-nefixestrada@gmail.com> Date: Sun, 28 Mar 2021 20:46:49 -0400 In-Reply-To: (Maxime Devos's message of "Sat, 27 Mar 2021 20:56:06 +0100") Message-ID: <874kgudbwm.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616978892; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uXVqh2PmQRMpKOYTkcJGsoU9LEqct4mPkn0mtlSF89Q=; b=jLMZLk+OFMePIrnb00j9rdgUhdvqB6AuOiVd7USeQqMcybKcz9M9xRc4MgzgabyXIJJilR FhYJl6DAb93V+pTOtaP5PACZVPd4OdbmZJ9VC3hzyGLyOs2z5zCRTvPLdkqsK1esm91Ldm vnIx6ZEz3EXknc2pQhCOc4EGFCC732e/ndfD6dffCDIEx9jm2gKoSrzSAMOluwSRF8SaTJ dwAa3QGIXvy44uOK6bzKVsyqLebVdw+DTiM3jtFHdMI9Q6lML8vFZVjtpqxdapwRbei5Sf 3R4x5pTbnEtc/OjAqaqMqiuKAIG54xfX+1CeMz6YYlvAWnvm09yGryWs7JRrKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616978892; a=rsa-sha256; cv=none; b=eCUe/CjJ+FnaT6m3zewIIyjpF6LxvnJ/6z6iZkpa+pgaSUuEx8mE+lKgJQEAY+BNaNTAfI BANx+php8GUwsxi0VS4FwZbr03rnVZogR6EaKD5a/08NEhZ8CtcXs7teR8Pjmgf9n0/DCe DXXtlpwPUOfZddYxUFV2iITd3ArcqPA6kY7z1N8XTGfxfeiYun3Jdbdeh3JfB/h1UhQATz GdW+jR6+Oxs8UHNsCbu3/hrBu6NYwwRQGgM5UFdrWdKPYZ6QR0KDphRNFdIy2dP4QBEqiQ +D2j0xVt71rCuIcP/8dOrmnF0gYDMRefpZyofD9qNO+nxCCkaaBbyg06+Qk9zA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=RWmLP6Sb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=RWmLP6Sb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1939017CA8 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: POsfA65wBlGf Hi, Maxime Devos writes: > On Sat, 2021-03-27 at 17:29 +0100, N=C3=A9fix Estrada wrote: >> Signed-off-by: N=C3=A9fix Estrada >> --- >> gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) > > A commit message is missing, see =E2=80=9816.6 Submitting Patches=E2=80= =99 in > the manual (and there are plenty of examples in "git log"). > > There have been a few patches lately by new > contributers without commit messages; is this section of the > manual hard to find? Is there some location where we could > prominently feature a link to the section? > > Also, =E2=80=98we=E2=80=99 don't use =E2=80=98Signed-off-by=E2=80=99 like= that. From =E2=80=9816.8 Commit Access=E2=80=99: > > When pushing a commit on behalf of somebody else, please add a > =E2=80=98Signed-off-by=E2=80=99 line at the end of the commit log message= =E2=80=94e.g., with > =E2=80=98git am --signoff=E2=80=99. This improves tracking of who did wh= at. > > Thus, it is up to committers to add a line like that. Perhaps a system > like the Linux kernel project uses could be useful in the future, > but I don't think =E2=80=98we=E2=80=99 are at that point yet > >> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm >> index d9988cd7ad..df17955c93 100644 >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm >> @@ -25,6 +25,7 @@ >> ;;; Copyright =C2=A9 2020 Martin Becze >> ;;; Copyright =C2=A9 2021 Ricardo Wurmus >> ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant >> +;;; Copyright =C2=A9 2021 N=C3=A9fix Estrada >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -440,6 +441,32 @@ in the style of communicating sequential processes = (@dfn{CSP}).") >> ,@(package-native-inputs go-1.4))) >> (supported-systems %supported-systems))) >>=20=20 >> +(define-public go-1.16 >> + (package >> + (inherit go-1.14) >> + [...] > >> + (arguments >> + (substitute-keyword-arguments (package-arguments go-1.14) >> + ((#:phases phases) >> + `(modify-phases ,phases > > This part looks good to me. > >> + (add-after 'prebuild 'prebuild-1-16 >> + (lambda* (#:key inputs #:allow-other-keys) >> + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/li= b"))) >> + (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt" >> + (("\\[\\!cgo\\] skip") >> + "[!exec:cc] skip"))))))))))) >> + > > What's this 'prebuild-1-16' phase for? Please add a comment explaining! > And what's (let* ((gcclib ...) ...) doing there if gcclib isn't used afte= rwards? > >> (define-public go go-1.14) > > Something to consider for people who know the go situation in guix: > could this be replaced with (define-public go go-1.16) after this patch? > (And go-1.14 deleted as there are no uses of it anymore.) > The output of "guix refresh --list-dependent go" is: > > Building the following 125 packages would ensure 440 dependent packages a= re rebuilt: > [...] > > so this shouldn't cause a world-rebuild (note go packages are (reportedly) > cheap to build). But perhaps there are API incompatibilities between 1.1= 6 and > 1.14? idk. Go 1.16 does break some go packages. I have a similar patch locally but I haven't pushed it yet because I was pursuing the different failures it causes. Maxim