* [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests.
@ 2022-11-02 7:03 jgart via Guix-patches via
2022-11-05 11:00 ` Christopher Baines
0 siblings, 1 reply; 2+ messages in thread
From: jgart via Guix-patches via @ 2022-11-02 7:03 UTC (permalink / raw)
To: 58963; +Cc: jgart
* gnu/packages/python-xyz.scm (python-funcparserlib): Enable tests.
[origin]: Use GitHub since it includes the tests unlike PyPi.
[build-system]: Use pyproject-build-system.
[arguments]: Run tests.
[native-inputs]: Add python-poetry-core.
---
gnu/packages/python-xyz.scm | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 1c2f9d7b73..eb5b74c993 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -25303,14 +25303,25 @@ (define-public python-funcparserlib
(name "python-funcparserlib")
(version "1.0.0")
(source
- (origin
- (method url-fetch)
- (uri (pypi-uri "funcparserlib" version))
- (sha256
- (base32 "0swbqf53x7lfnczvi566s1g3nkf5mfrxz7sbpyymricz57a3vlvx"))))
- (build-system python-build-system)
+ (origin
+ ;; Source tarball on PyPi lacks tests.
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/vlasovskikh/funcparserlib")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "00pswdys5c4hpqpvfcy5zqv30gyjvjvagi12811jizw57hxrm1cs"))))
+ (build-system pyproject-build-system)
(arguments
- `(#:tests? #f)) ; no tests in PyPI and no setup.py in GitHub
+ '(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "python" "-m" "unittest" "discover" "-v")))))))
+ ;; ModuleNotFoundError: No module named 'poetry'
+ (native-inputs (list python-poetry-core))
(home-page "https://github.com/vlasovskikh/funcparserlib")
(synopsis
"Recursive descent parsing library based on functional combinators")
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests.
2022-11-02 7:03 [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests jgart via Guix-patches via
@ 2022-11-05 11:00 ` Christopher Baines
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2022-11-05 11:00 UTC (permalink / raw)
To: jgart; +Cc: 58963-done, 58963
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/python-xyz.scm (python-funcparserlib): Enable tests.
> [origin]: Use GitHub since it includes the tests unlike PyPi.
> [build-system]: Use pyproject-build-system.
> [arguments]: Run tests.
> [native-inputs]: Add python-poetry-core.
> ---
> gnu/packages/python-xyz.scm | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
Looks good to me, I've pushed to master as
f91713e71b6bc1222c8f5b218dede3dc7e670a3c.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-05 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 7:03 [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests jgart via Guix-patches via
2022-11-05 11:00 ` Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).