[bug#29432] [PATCH] gnu: diffoscope: Fix error messages related to comparison tools.

[Kei Kebreau <kkebreau@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote:
>> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace readelf
>> substitution and add stat and getfacl substitutions.
>> [inputs]: Add acl.
>
> Can you add an example of the error messages in the commit message?
> Otherwise LGTM.
>

Like this?

Errors fixed include the following:
  "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'"
  "diffoscope.comparators.directory: Unable to find 'getfacl', some
   directory metadata differences might not be noticed."
  "diffoscope.comparators.directory: Unable to find 'stat'"
>> @@ -520,7 +521,6 @@ transactions from C or Python.")
>>      (build-system python-build-system)
>>      (arguments
>>       `(#:phases (modify-phases %standard-phases
>> -                  (add-before 'unpack 'n (lambda _ #t))
>>                    ;; setup.py mistakenly requires python-magic from PyPi, even
>>                    ;; though the Python bindings of `file` are sufficient.
>>                    ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815844
>
> Some leftover debugging? :)

You know it! ;)
I figured out that this is unnecessary if one uses --keep-failed when
building with multiple rounds.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]