From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIedV-0005KQ-PA for guix-patches@gnu.org; Sat, 25 Nov 2017 12:53:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIedS-0003Rr-NS for guix-patches@gnu.org; Sat, 25 Nov 2017 12:53:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:49469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIedS-0003Rl-Fb for guix-patches@gnu.org; Sat, 25 Nov 2017 12:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eIedS-0007B2-5m for guix-patches@gnu.org; Sat, 25 Nov 2017 12:53:02 -0500 Subject: [bug#29432] [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. Resent-Message-ID: From: Kei Kebreau In-Reply-To: <20171125001716.GC17061@jasmine.lan> (Leo Famulari's message of "Fri, 24 Nov 2017 19:17:16 -0500") References: <20171124210958.10089-1-kkebreau@posteo.net> <20171125001716.GC17061@jasmine.lan> Date: Sat, 25 Nov 2017 12:51:52 -0500 Message-ID: <873752jlfr.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 29432@debbugs.gnu.org --=-=-= Content-Type: text/plain Leo Famulari writes: > On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote: >> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace readelf >> substitution and add stat and getfacl substitutions. >> [inputs]: Add acl. > > Can you add an example of the error messages in the commit message? > Otherwise LGTM. > Like this? Errors fixed include the following: "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'" "diffoscope.comparators.directory: Unable to find 'getfacl', some directory metadata differences might not be noticed." "diffoscope.comparators.directory: Unable to find 'stat'" >> @@ -520,7 +521,6 @@ transactions from C or Python.") >> (build-system python-build-system) >> (arguments >> `(#:phases (modify-phases %standard-phases >> - (add-before 'unpack 'n (lambda _ #t)) >> ;; setup.py mistakenly requires python-magic from PyPi, even >> ;; though the Python bindings of `file` are sufficient. >> ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815844 > > Some leftover debugging? :) You know it! ;) I figured out that this is unnecessary if one uses --keep-failed when building with multiple rounds. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAloZrbgACgkQ5qXuPBlG eg2GwhAAo3rU69Zbrzltemw89CXZWp80HhTsG2NwVGT1knybrPV2OjpMsZK8iZeG vfIEoTF8m9x8Qj514vMvwd5+AODTuA21K35p8Jl02EKNEN3MPzuc/AlBhJwNm5dE oc7HDz6n5csgi7o07DYPBeeX87oPiJdvo3eI/kF3WZWGgm7HBqVXy6tVkNUE6GxC MRl7qhb8In0V1XK5xXJ/geLDn2vgt8zOr0aAIm/qqs3Hlymk4jNXWIMlO1mCz8Oc ExokFWLhUyz9cJKVvO1GL3jDbsDrg6DzcLS5o2c7zRwvNHbiR7QlFaIrSrfLytQj kYAMPuCjzpb4GSautFrePvnPT+2fw3fIPf2JNFak0aCxfENZiV0lWGZfvBkVPxUX SgMQNMZHu4oOc2KL+UMiGkT7V4WmjjDwBsRbyfEouJBNbKGflPwE81T//16K2EyG cOeVSyJl7hBcVra/xH2OINp0QAaXdUPBQB2K+MhheUlnW0kpwGyPW2HI14rECQNB k90CaeoYMV1hln+rs1U1xpk3Wh5phIdPyqEjNgTVLgt6qmpTJWrciPvBo+EjJb6G 21wxK352PxxvEPcv5o9vdFyB5ISZyWsQ2HPFgKmTKMDa7KhFS5O0A08IiTg47CUD ICC1iOO4pJO+G7/7aC6cMv3zFrKdR+O5b6UaPNrHIxFiUr9qV8Y= =Pd7L -----END PGP SIGNATURE----- --=-=-=--