* [bug#37277] [PATCHES] Thunar: Update to 1.8.9.
@ 2019-09-02 14:10 L p R n d n
2019-09-08 12:33 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: L p R n d n @ 2019-09-02 14:10 UTC (permalink / raw)
To: 37277
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0013-gnu-Thunar-Update-to-1.8.9.patch --]
[-- Type: text/x-patch, Size: 1455 bytes --]
From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Mon, 19 Aug 2019 14:01:52 +0200
Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
* gnu/packages/xfce.scm (thunar): Update to 1.8.9.
[propagated-inputs] Add gtk+.
---
gnu/packages/xfce.scm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b27e489678..db8387b9ad 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
(define-public thunar
(package
(name "thunar")
- (version "1.8.7")
+ (version "1.8.9")
(source (origin
(method url-fetch)
(uri (string-append "http://archive.xfce.org/src/xfce/"
@@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")
"Thunar-" version ".tar.bz2"))
(sha256
(base32
- "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
+ "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
(build-system gnu-build-system)
(native-inputs
`(("pkg-config" ,pkg-config)
("intltool" ,intltool)))
+ (propagated-inputs
+ ;; Required by thunarx-3.pc
+ `(("gtk+" ,gtk+)))
(inputs
`(("exo" ,exo)
("libexif" ,libexif)
--
2.22.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0014-gnu-Thunar-Add-gobject-introspection-support.patch --]
[-- Type: text/x-patch, Size: 842 bytes --]
From d060bbbe43867160abbe2be836d1ebb035007c80 Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Mon, 19 Aug 2019 14:03:37 +0200
Subject: [PATCH 14/19] gnu: Thunar: Add gobject-introspection support.
* gnu/packages/xfce.scm (thunar)[native-inputs]: Add gobject-introspection.
---
gnu/packages/xfce.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index db8387b9ad..53379b2d2c 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -653,6 +653,7 @@ like appearance, display, keyboard and mouse settings.")
(build-system gnu-build-system)
(native-inputs
`(("pkg-config" ,pkg-config)
+ ("gobject-introspection" ,gobject-introspection)
("intltool" ,intltool)))
(propagated-inputs
;; Required by thunarx-3.pc
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#37277] [PATCHES] Thunar: Update to 1.8.9.
2019-09-02 14:10 [bug#37277] [PATCHES] Thunar: Update to 1.8.9 L p R n d n
@ 2019-09-08 12:33 ` Ludovic Courtès
2019-09-12 8:18 ` L p R n d n
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-09-08 12:33 UTC (permalink / raw)
To: L p R n d n; +Cc: 37277
L p R n d n <guix@lprndn.info> skribis:
>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001
> From: L p R n d n <guix@lprndn.info>
> Date: Mon, 19 Aug 2019 14:01:52 +0200
> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
>
> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
> [propagated-inputs] Add gtk+.
> ---
> gnu/packages/xfce.scm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index b27e489678..db8387b9ad 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
> (define-public thunar
> (package
> (name "thunar")
> - (version "1.8.7")
> + (version "1.8.9")
> (source (origin
> (method url-fetch)
> (uri (string-append "http://archive.xfce.org/src/xfce/"
> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")
> "Thunar-" version ".tar.bz2"))
> (sha256
> (base32
> - "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
> + "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
> (build-system gnu-build-system)
> (native-inputs
> `(("pkg-config" ,pkg-config)
> ("intltool" ,intltool)))
> + (propagated-inputs
> + ;; Required by thunarx-3.pc
> + `(("gtk+" ,gtk+)))
Hi! We usually propagated in similar cases. However, here that would
lead to propagating all of gtk+ to the user’s profile, which is
undesirable. Furthermore, since thunar has only two dependents, it’s
probably not a problem if we don’t propagate gtk+.
WDYT?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#37277] [PATCHES] Thunar: Update to 1.8.9.
2019-09-08 12:33 ` Ludovic Courtès
@ 2019-09-12 8:18 ` L p R n d n
2019-09-13 8:29 ` bug#37277: " Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: L p R n d n @ 2019-09-12 8:18 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 37277
[-- Attachment #1: Type: text/plain, Size: 2237 bytes --]
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> L p R n d n <guix@lprndn.info> skribis:
>
>>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001
>> From: L p R n d n <guix@lprndn.info>
>> Date: Mon, 19 Aug 2019 14:01:52 +0200
>> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
>>
>> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
>> [propagated-inputs] Add gtk+.
>> ---
>> gnu/packages/xfce.scm | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
>> index b27e489678..db8387b9ad 100644
>> --- a/gnu/packages/xfce.scm
>> +++ b/gnu/packages/xfce.scm
>> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
>> (define-public thunar
>> (package
>> (name "thunar")
>> - (version "1.8.7")
>> + (version "1.8.9")
>> (source (origin
>> (method url-fetch)
>> (uri (string-append "http://archive.xfce.org/src/xfce/"
>> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")
>> "Thunar-" version ".tar.bz2"))
>> (sha256
>> (base32
>> - "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
>> + "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
>> (build-system gnu-build-system)
>> (native-inputs
>> `(("pkg-config" ,pkg-config)
>> ("intltool" ,intltool)))
>> + (propagated-inputs
>> + ;; Required by thunarx-3.pc
>> + `(("gtk+" ,gtk+)))
>
> Hi! We usually propagated in similar cases. However, here that would
> lead to propagating all of gtk+ to the user’s profile, which is
> undesirable. Furthermore, since thunar has only two dependents, it’s
> probably not a problem if we don’t propagate gtk+.
>
> WDYT?
I don't have enough knowledge about how this works to give a useful hint
here so I would probably just follow your advice. Yet I quickly tested without
propagated-inputs and it seems to work without trouble.
So here is the new patch.
> Thanks,
> Ludo’.
Thank you and have a nice day,
L p R n d n
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Thunar-Update-to-1.8.9.patch --]
[-- Type: text/x-patch, Size: 1235 bytes --]
From f57c21a46a0cdf23085195e3645b4f1aae9e8cbd Mon Sep 17 00:00:00 2001
From: L p R n d n <guix@lprndn.info>
Date: Mon, 19 Aug 2019 14:01:52 +0200
Subject: [PATCH] gnu: Thunar: Update to 1.8.9.
* gnu/packages/xfce.scm (thunar): Update to 1.8.9.
---
gnu/packages/xfce.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b27e489678..8ddb7ae8a7 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
(define-public thunar
(package
(name "thunar")
- (version "1.8.7")
+ (version "1.8.9")
(source (origin
(method url-fetch)
(uri (string-append "http://archive.xfce.org/src/xfce/"
@@ -649,7 +649,7 @@ like appearance, display, keyboard and mouse settings.")
"Thunar-" version ".tar.bz2"))
(sha256
(base32
- "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
+ "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
(build-system gnu-build-system)
(native-inputs
`(("pkg-config" ,pkg-config)
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#37277: [PATCHES] Thunar: Update to 1.8.9.
2019-09-12 8:18 ` L p R n d n
@ 2019-09-13 8:29 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-09-13 8:29 UTC (permalink / raw)
To: L p R n d n; +Cc: 37277-done
Hi,
L p R n d n <guix@lprndn.info> skribis:
> From f57c21a46a0cdf23085195e3645b4f1aae9e8cbd Mon Sep 17 00:00:00 2001
> From: L p R n d n <guix@lprndn.info>
> Date: Mon, 19 Aug 2019 14:01:52 +0200
> Subject: [PATCH] gnu: Thunar: Update to 1.8.9.
>
> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-13 8:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 14:10 [bug#37277] [PATCHES] Thunar: Update to 1.8.9 L p R n d n
2019-09-08 12:33 ` Ludovic Courtès
2019-09-12 8:18 ` L p R n d n
2019-09-13 8:29 ` bug#37277: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).