From: Marius Bakke <mbakke@fastmail.com>
To: Tanguy Le Carrour <tanguy@bioneland.org>
Cc: 38208@debbugs.gnu.org
Subject: [bug#38208] [PATCH] gnu: Add python-3.8.
Date: Tue, 19 Nov 2019 21:51:56 +0100 [thread overview]
Message-ID: <8736eja8sz.fsf@devup.no> (raw)
In-Reply-To: <20191119082628.2ysfzwpm4o7lpeln@rafflesia>
[-- Attachment #1: Type: text/plain, Size: 2915 bytes --]
Tanguy Le Carrour <tanguy@bioneland.org> writes:
> Hi Marius,
>
>
> Le 11/15, Marius Bakke a écrit :
>> Tanguy Le Carrour <tanguy@bioneland.org> writes:
>> > ++ @unittest.skipIf(True, "This fails for unknown reasons on Guix")
>> > + def test_keyboard_interrupt_exit_code(self):
>> > + """KeyboardInterrupt triggers exit via SIGINT."""
>> > + process = subprocess.run(
>>
>> I'm fairly confident that these failures are because stdin is not a
>> TTY. Can you try changing to this?
>>
>> @unittest.skipUnless(sys.stdin.isatty(), "KeyboardInterrupts require a TTY device")
>>
>> It would be good to submit a patch along these lines upstream if that
>> works.
>
> Thanks for the snippet! It works!
>
> I've been trying for 2 days to register on https://bugs.python.org to submit
> this patch, but failed! :-(
> I'll keep on trying with different email addresses…
Excellent, thank you very much for taking care of this. There are five
other tests skipped for the same reason in 'python-3-fix-tests.patch',
can you include those in the upstream pull request?
> Does this mean that we have to wait for upstream to integrate it, or can
> we use the patched wersion for Guix?
I think the patch looks OK, but looking forward to hear upstreams take
on it. In any case, it should not be a blocker.
> Anyway, I'll update this patch according to your suggestion and push it.
Push it to this bug report, presumably? :-)
>> One final question... Do you know how stable the Python ABI is? Are
>> packages compiled with 3.7 guaranteed to work with 3.8?
>>
>> I wonder if we should 1) rename it to 'python-next', and 2) override
>> 'native-search-paths' so that it searches 'lib/python3.8/site-packages'.
>>
>> My concern is that e.g. 'guix environment --ad-hoc python python-numpy'
>> might stop working unless we rename it, and/or adjust search paths.
>>
>> If Python 3.8 is fully backwards compatible, we probably don't have to
>> do anything, otherwise we should adjust accordingly.
>
> I don't know anything about ABI, but what I read here:
> https://www.python.org/dev/peps/pep-0384/
> So I guess it's been taken into consideration!
Cool, thanks for the link. So it is safe to swap out Python 3.7 with
3.8 "in-place". However I think we should still call it differently,
because the new Python won't necessarily be compatible with all the
manifests/environments out there that reference Python by name.
So if you send a patch that adds (name "python-next") to the inherited
Python package, I think we are all set.
Thank you!
> I might have some time later this week to test using Python 3.8 as
> default Python. I'll let you know!
Great, good luck! I suspect you'll have to update many of the 'core'
Python packages along the way; feel free to drop by #guix on Freenode if
you get stuck anywhere. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-11-19 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:44 [bug#38208] [PATCH] gnu: Add python-3.8 Tanguy Le Carrour
2019-11-15 17:28 ` Marius Bakke
2019-11-19 8:26 ` Tanguy Le Carrour
2019-11-19 20:51 ` Marius Bakke [this message]
2019-11-19 8:50 ` [bug#38208] [PATCH v2] " Tanguy Le Carrour
2019-11-19 20:54 ` bug#38208: " Marius Bakke
[not found] ` <handler.38208.B.157372113024712.ack@debbugs.gnu.org>
2019-11-19 10:33 ` [bug#38208] Acknowledgement ([PATCH] gnu: Add python-3.8.) Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736eja8sz.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=38208@debbugs.gnu.org \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).