From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54713) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXAUh-0003Ek-Io for guix-patches@gnu.org; Tue, 19 Nov 2019 15:53:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXAUg-0003mn-74 for guix-patches@gnu.org; Tue, 19 Nov 2019 15:53:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXAUf-0003mf-W5 for guix-patches@gnu.org; Tue, 19 Nov 2019 15:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXAUf-0000Vz-T1 for guix-patches@gnu.org; Tue, 19 Nov 2019 15:53:01 -0500 Subject: [bug#38208] [PATCH] gnu: Add python-3.8. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20191119082628.2ysfzwpm4o7lpeln@rafflesia> References: <20191114084453.27042-1-tanguy@bioneland.org> <874kz5giav.fsf@devup.no> <20191119082628.2ysfzwpm4o7lpeln@rafflesia> Date: Tue, 19 Nov 2019 21:51:56 +0100 Message-ID: <8736eja8sz.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tanguy Le Carrour Cc: 38208@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tanguy Le Carrour writes: > Hi Marius, > > > Le 11/15, Marius Bakke a =C3=A9crit : >> Tanguy Le Carrour writes: >> > ++ @unittest.skipIf(True, "This fails for unknown reasons on Guix") >> > + def test_keyboard_interrupt_exit_code(self): >> > + """KeyboardInterrupt triggers exit via SIGINT.""" >> > + process =3D subprocess.run( >>=20 >> I'm fairly confident that these failures are because stdin is not a >> TTY. Can you try changing to this? >>=20 >> @unittest.skipUnless(sys.stdin.isatty(), "KeyboardInterrupts require a T= TY device") >>=20 >> It would be good to submit a patch along these lines upstream if that >> works. > > Thanks for the snippet! It works! > > I've been trying for 2=C2=A0days to register on https://bugs.python.org t= o submit > this patch, but failed! :-( > I'll keep on trying with different email addresses=E2=80=A6 Excellent, thank you very much for taking care of this. There are five other tests skipped for the same reason in 'python-3-fix-tests.patch', can you include those in the upstream pull request? > Does this mean that we have to wait for upstream to integrate it, or can > we use the patched wersion for Guix? I think the patch looks OK, but looking forward to hear upstreams take on it. In any case, it should not be a blocker. > Anyway, I'll update this patch according to your suggestion and push it. Push it to this bug report, presumably? :-) >> One final question... Do you know how stable the Python ABI is? Are >> packages compiled with 3.7 guaranteed to work with 3.8? >>=20 >> I wonder if we should 1) rename it to 'python-next', and 2) override >> 'native-search-paths' so that it searches 'lib/python3.8/site-packages'. >>=20 >> My concern is that e.g. 'guix environment --ad-hoc python python-numpy' >> might stop working unless we rename it, and/or adjust search paths. >>=20 >> If Python 3.8 is fully backwards compatible, we probably don't have to >> do anything, otherwise we should adjust accordingly. > > I don't know anything about ABI, but what I read here: > https://www.python.org/dev/peps/pep-0384/ > So I guess it's been taken into consideration! Cool, thanks for the link. So it is safe to swap out Python 3.7 with 3.8 "in-place". However I think we should still call it differently, because the new Python won't necessarily be compatible with all the manifests/environments out there that reference Python by name. So if you send a patch that adds (name "python-next") to the inherited Python package, I think we are all set. Thank you! > I might have some time later this week to test using Python 3.8 as > default Python. I'll let you know! Great, good luck! I suspect you'll have to update many of the 'core' Python packages along the way; feel free to drop by #guix on Freenode if you get stuck anywhere. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3UVewACgkQoqBt8qM6 VPpctwf/dKk7tezwPT3VQIMWq4qBNTyGdIUYTFI9MFXzAatPfLnwcjforiDQjq2y zveBXxhB6GZrcn81k83gt/N3WpMS0+k0NVafQmcDfaVttH0gnmUymsFKPxyVxF8B dSYM7DE65F+DOzA2OrkIEmgjOii682X57T6cI41lLBq9xW7DeeSbFnVJW5+AnFfK 2mkpC2lbEldOa/BeMw2S7yy0x9ux2RXm5YB/fpOoSvMTtJMxYDGjE0xuJbu6Q/0c bA2uCdG0kFErldy7JWdjPn6ZpKsc+kv/+EH+ktIVTCMhD5Ip9Wri9RLoQxMqpJ/A lgRK0dKJjwOfM9iyqOPnNHV15YTGsw== =9QNM -----END PGP SIGNATURE----- --=-=-=--