From: Brett Gilio <brettg@posteo.net>
To: Leo Famulari <leo@famulari.name>
Cc: 38477@debbugs.gnu.org
Subject: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.
Date: Tue, 03 Dec 2019 21:06:28 -0600 [thread overview]
Message-ID: <8736e0iybv.fsf@posteo.net> (raw)
In-Reply-To: <edfb218139346f926361bfe0be51e148cd7488ee.1575403175.git.leo@famulari.name> (Leo Famulari's message of "Tue, 3 Dec 2019 15:00:27 -0500")
Leo Famulari <leo@famulari.name> writes:
> This should improve the "user experience" when querying the status of
> the SSH service. We could even add program specific strings like
> "lshd", "dropbear", and "openssh". Thoughts?
I think this is a good idea. It would add a lot of granular
control. However, we would need to make sure this is a standard used for
other SSH options in the future.
> * gnu/services/ssh.scm (lsh-shepherd-service, dropbear-shepherd-service,
> openssh-sheperd-service): Add 'ssh' and 'sshd' to provision.
> ---
> gnu/services/ssh.scm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
> index ced1991fba..7e25810eff 100644
> --- a/gnu/services/ssh.scm
> +++ b/gnu/services/ssh.scm
> @@ -174,7 +174,7 @@
>
> (list (shepherd-service
> (documentation "GNU lsh SSH server")
> - (provision '(ssh-daemon))
> + (provision '(ssh-daemon ssh sshd))
> (requirement requires)
> (start #~(make-forkexec-constructor (list #$@lsh-command)))
> (stop #~(make-kill-destructor)))))
> @@ -511,7 +511,7 @@ of user-name/file-like tuples."
> (list (shepherd-service
> (documentation "OpenSSH server.")
> (requirement '(syslogd loopback))
> - (provision '(ssh-daemon))
> + (provision '(ssh-daemon ssh sshd))
> (start #~(make-forkexec-constructor #$openssh-command
> #:pid-file #$pid-file))
> (stop #~(make-kill-destructor))
> @@ -620,7 +620,7 @@ of user-name/file-like tuples."
> (list (shepherd-service
> (documentation "Dropbear SSH server.")
> (requirement requires)
> - (provision '(ssh-daemon))
> + (provision '(ssh-daemon ssh sshd))
> (start #~(make-forkexec-constructor #$dropbear-command
> #:pid-file #$pid-file))
> (stop #~(make-kill-destructor)))))
LGTM! Very simple solution. Should be easy to cross-implement to other uses.
--
Brett M. Gilio
https://git.sr.ht/~brettgilio/
next prev parent reply other threads:[~2019-12-04 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 20:00 [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services Leo Famulari
2019-12-04 3:06 ` Brett Gilio [this message]
2019-12-04 13:32 ` bug#38477: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736e0iybv.fsf@posteo.net \
--to=brettg@posteo.net \
--cc=38477@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).