From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:49121) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icL0T-000080-Mz for guix-patches@gnu.org; Tue, 03 Dec 2019 22:07:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icL0K-0000jq-EN for guix-patches@gnu.org; Tue, 03 Dec 2019 22:07:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icL0J-0000f9-9M for guix-patches@gnu.org; Tue, 03 Dec 2019 22:07:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icL0I-0007FN-3r for guix-patches@gnu.org; Tue, 03 Dec 2019 22:07:02 -0500 Subject: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services. Resent-Message-ID: From: Brett Gilio References: Date: Tue, 03 Dec 2019 21:06:28 -0600 In-Reply-To: (Leo Famulari's message of "Tue, 3 Dec 2019 15:00:27 -0500") Message-ID: <8736e0iybv.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 38477@debbugs.gnu.org Leo Famulari writes: > This should improve the "user experience" when querying the status of > the SSH service. We could even add program specific strings like > "lshd", "dropbear", and "openssh". Thoughts? I think this is a good idea. It would add a lot of granular control. However, we would need to make sure this is a standard used for other SSH options in the future. > * gnu/services/ssh.scm (lsh-shepherd-service, dropbear-shepherd-service, > openssh-sheperd-service): Add 'ssh' and 'sshd' to provision. > --- > gnu/services/ssh.scm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm > index ced1991fba..7e25810eff 100644 > --- a/gnu/services/ssh.scm > +++ b/gnu/services/ssh.scm > @@ -174,7 +174,7 @@ > > (list (shepherd-service > (documentation "GNU lsh SSH server") > - (provision '(ssh-daemon)) > + (provision '(ssh-daemon ssh sshd)) > (requirement requires) > (start #~(make-forkexec-constructor (list #$@lsh-command))) > (stop #~(make-kill-destructor))))) > @@ -511,7 +511,7 @@ of user-name/file-like tuples." > (list (shepherd-service > (documentation "OpenSSH server.") > (requirement '(syslogd loopback)) > - (provision '(ssh-daemon)) > + (provision '(ssh-daemon ssh sshd)) > (start #~(make-forkexec-constructor #$openssh-command > #:pid-file #$pid-file)) > (stop #~(make-kill-destructor)) > @@ -620,7 +620,7 @@ of user-name/file-like tuples." > (list (shepherd-service > (documentation "Dropbear SSH server.") > (requirement requires) > - (provision '(ssh-daemon)) > + (provision '(ssh-daemon ssh sshd)) > (start #~(make-forkexec-constructor #$dropbear-command > #:pid-file #$pid-file)) > (stop #~(make-kill-destructor))))) LGTM! Very simple solution. Should be easy to cross-implement to other uses. -- Brett M. Gilio https://git.sr.ht/~brettgilio/