unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alberto EFG <albertoefg@posteo.mx>
Cc: 40593-done@debbugs.gnu.org
Subject: bug#40593: Added emacs-uml-mode
Date: Tue, 14 Apr 2020 11:12:33 +0200	[thread overview]
Message-ID: <873696whvi.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87wo6j7vxu.fsf@posteo.mx> (Alberto EFG's message of "Mon, 13 Apr 2020 01:15:41 -0500")

Hello,

Alberto EFG <albertoefg@posteo.mx> writes:

> Added emacs-uml-mode. I used the same branch where I wrote
> emacs-org-roam (bug#40591) hope it is ok.

Thank you.

Note that adding all new packages at the end of the file is likely to
create merge conflicts. If they are tied, send them in the same bug
report.

> +(define-public emacs-uml-mode
> +  (package
> +   (name "emacs-uml-mode")
> +   (version "0.0.4")

This is not an official release. So I added a commit, a revision, and
a comment. Therefore, the line became:

  (version (git-version "0.0.4" revision commit))

> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url "https://github.com/ianxm/emacs-uml.git")
> +           (commit "4c37ac1c4424b2313cd8f16ba48a98a4cc214200")))

As a consequence of the "no revision" situation, the line above  became:

  (commit commit)

> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32
> +       "145i4srnfvd1vyibri2a1l6p9mbjvkkwlrpi41134pbarqffcnka"))))
> +   (build-system emacs-build-system)
> +   (home-page "https://github.com/ianxm/emacs-uml")
> +   (synopsis "Minor mode for editing ascii UML sequence diagrams")
> +   (description "@code{emacs-uml-mode} is a minor mode that
> + makes it easy to build ascii UML sequence diagrams in Emacs,
> +which can be embedded in source code, comments or emails.")
> +   (license license:gpl3)))

Please also see my comments about "emacs-org-roam" (indentation, commit,
license).

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2020-04-14  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13  6:15 [bug#40593] Added emacs-uml-mode Alberto EFG
2020-04-14  9:12 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873696whvi.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=40593-done@debbugs.gnu.org \
    --cc=albertoefg@posteo.mx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).