From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:57534) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOHcu-0006qK-Qi for guix-patches@gnu.org; Tue, 14 Apr 2020 05:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOHct-0003Og-OE for guix-patches@gnu.org; Tue, 14 Apr 2020 05:13:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOHcs-0003ME-Ac for guix-patches@gnu.org; Tue, 14 Apr 2020 05:13:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOHcs-0004oO-71 for guix-patches@gnu.org; Tue, 14 Apr 2020 05:13:02 -0400 Subject: bug#40593: Added emacs-uml-mode Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Nicolas Goaziou References: <87wo6j7vxu.fsf@posteo.mx> Date: Tue, 14 Apr 2020 11:12:33 +0200 In-Reply-To: <87wo6j7vxu.fsf@posteo.mx> (Alberto EFG's message of "Mon, 13 Apr 2020 01:15:41 -0500") Message-ID: <873696whvi.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alberto EFG Cc: 40593-done@debbugs.gnu.org Hello, Alberto EFG writes: > Added emacs-uml-mode. I used the same branch where I wrote > emacs-org-roam (bug#40591) hope it is ok. Thank you. Note that adding all new packages at the end of the file is likely to create merge conflicts. If they are tied, send them in the same bug report. > +(define-public emacs-uml-mode > + (package > + (name "emacs-uml-mode") > + (version "0.0.4") This is not an official release. So I added a commit, a revision, and a comment. Therefore, the line became: (version (git-version "0.0.4" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ianxm/emacs-uml.git") > + (commit "4c37ac1c4424b2313cd8f16ba48a98a4cc214200"))) As a consequence of the "no revision" situation, the line above became: (commit commit) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "145i4srnfvd1vyibri2a1l6p9mbjvkkwlrpi41134pbarqffcnka")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/ianxm/emacs-uml") > + (synopsis "Minor mode for editing ascii UML sequence diagrams") > + (description "@code{emacs-uml-mode} is a minor mode that > + makes it easy to build ascii UML sequence diagrams in Emacs, > +which can be embedded in source code, comments or emails.") > + (license license:gpl3))) Please also see my comments about "emacs-org-roam" (indentation, commit, license). Regards, -- Nicolas Goaziou