unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Taiju HIGASHI <higashi@taiju.info>
Cc: 57694-done@debbugs.gnu.org
Subject: bug#57694: [PATCH 1/1] import: gem: Support for importing a specified version of a gem.
Date: Sat, 17 Sep 2022 19:18:41 +0200	[thread overview]
Message-ID: <8735cpsyu0.fsf@cbaines.net> (raw)
In-Reply-To: <87o7vie0v2.fsf@taiju.info>

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]


Taiju HIGASHI <higashi@taiju.info> writes:

> Hi Chris,
>
> Could you give me your opinion on this patch?
> Is this patch worth it?

Hey,

Unfortunately I haven't had much time to look at Ruby stuff recently,
but these changes look good to me. I tweaked a few minor things and
pushed this as c967d1153cae419e4acbe0dbed8f558d95ced0e3.

Thanks,

Chris

> Taiju HIGASHI <higashi@taiju.info> writes:
>
>> * guix/import/gem.scm: (rubygems-fetch, gem->guix-package)
>> (gem-recursive-import): Fix to fetch the specified version of the gem.
>> * guix/scripts/import/gem.scm (show-help): Modify the help message.
>> (guix-import-gem): Modify the version number to be passed to subsequent
>> procedures
>> * tests/gem.scm: Add tests.
>> ---
>>  guix/import/gem.scm         |  19 ++++--
>>  guix/scripts/import/gem.scm |  39 +++++++------
>>  tests/gem.scm               | 113 ++++++++++++++++++++++++++++++++++++
>>  3 files changed, 148 insertions(+), 23 deletions(-)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2022-09-17 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 13:44 [bug#57694] [PATCH 0/1] Support for importing a specified version of a gem Taiju HIGASHI
2022-09-09 13:47 ` [bug#57694] [PATCH 1/1] import: gem: " Taiju HIGASHI
2022-09-14  9:55   ` Taiju HIGASHI
2022-09-17 17:18     ` Christopher Baines [this message]
2022-09-17 23:52       ` Taiju HIGASHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735cpsyu0.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=57694-done@debbugs.gnu.org \
    --cc=higashi@taiju.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).