From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +BstLc8BJmN+bwAAbAwnHQ (envelope-from ) for ; Sat, 17 Sep 2022 19:20:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MHgqLc8BJmPgwAAA9RJhRA (envelope-from ) for ; Sat, 17 Sep 2022 19:20:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72DA012705 for ; Sat, 17 Sep 2022 19:20:15 +0200 (CEST) Received: from localhost ([::1]:53936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZbUD-00085c-JE for larch@yhetil.org; Sat, 17 Sep 2022 13:20:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZbU2-000853-Qb for guix-patches@gnu.org; Sat, 17 Sep 2022 13:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZbU2-0000tE-Hf for guix-patches@gnu.org; Sat, 17 Sep 2022 13:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZbU2-0007Ec-DO for guix-patches@gnu.org; Sat, 17 Sep 2022 13:20:02 -0400 Subject: bug#57694: [PATCH 1/1] import: gem: Support for importing a specified version of a gem. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 17 Sep 2022 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57694 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Taiju HIGASHI Cc: 57694-done@debbugs.gnu.org Mail-Followup-To: 57694@debbugs.gnu.org, mail@cbaines.net, higashi@taiju.info Received: via spool by 57694-done@debbugs.gnu.org id=D57694.166343518827783 (code D ref 57694); Sat, 17 Sep 2022 17:20:02 +0000 Received: (at 57694-done) by debbugs.gnu.org; 17 Sep 2022 17:19:48 +0000 Received: from localhost ([127.0.0.1]:47087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZbTo-0007E2-8p for submit@debbugs.gnu.org; Sat, 17 Sep 2022 13:19:48 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZbTh-0007Dp-QR for 57694-done@debbugs.gnu.org; Sat, 17 Sep 2022 13:19:47 -0400 Received: from localhost (unknown [134.157.22.165]) by mira.cbaines.net (Postfix) with ESMTPSA id 640D927BBE9; Sat, 17 Sep 2022 18:19:38 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 0aeaf013; Sat, 17 Sep 2022 17:19:38 +0000 (UTC) References: <20220909134736.18808-2-higashi@taiju.info> <87o7vie0v2.fsf@taiju.info> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines Date: Sat, 17 Sep 2022 19:18:41 +0200 In-reply-to: <87o7vie0v2.fsf@taiju.info> Message-ID: <8735cpsyu0.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663435215; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=e338AJxYaOaAMTIpjMBGTJkq89Ew3pZgIVnq8JvzV2k=; b=KJQT44vRT2g24dXp11GT1XqgqxH2Ynq0dXTPgTRvX0ZapVNjYh4967UJwNZx+z1HAaNfXp 3+gD8br+sHvwXncpf/07zuJjYKMec27MHlPaAKb1JINdV+j3pMwQR9EpVcwk6VzNb97OSw DefkFIxRDI57Lwmd45IwMtRP8cJLIi0P4Ya2H/9rfyMDXW6Y5p7WRahTS/+/796N99rbEc AdeN4pRXeD/9+vIRNZP76VDLm5y8WLd6Izzh8LuuAlZ0VlNjRiNS4t0yKHcJJs03zPRT6U TjzhgBKlNZhLNuOnlG90mKnDINzaVHlNnnelA2EcV94ZUlOluvrHarn18y7kDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663435215; a=rsa-sha256; cv=none; b=Xe6kXc5ZJpJR6K2jka96t+hagF/0l0Qpc693DiaZr4KC5+NyYPvWS6ToBKBAkmCP9ei0/F CXd1CMUfU1ay9s/PNKWbwqX18DgU6IZQpBHkj8hvaInaUjf9by3uuI8LNX5ojATsn8XJhw 0xQzEGHyg14/lB75JWcX9Mm9acaXe4Z64z/OzWsNyfZhWaXQ+ucaBIKhkXwVaB8BsDLkCX XgYp79+0hVJFq63hiB9LmeMZSqgiUh4UCilCuVHigfOI2LbjOMt6xfEa2MKK0mxEYmhhbG khy11FVW1j2xyVsT3FpvpDOpvbQMz4ZsF/wKqQdV9x1Dtn+RJCtlWl/f+HKCpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 72DA012705 X-Spam-Score: -4.94 X-Migadu-Scanner: scn1.migadu.com X-TUID: MEqzLOuQiyXj --=-=-= Content-Type: text/plain Taiju HIGASHI writes: > Hi Chris, > > Could you give me your opinion on this patch? > Is this patch worth it? Hey, Unfortunately I haven't had much time to look at Ruby stuff recently, but these changes look good to me. I tweaked a few minor things and pushed this as c967d1153cae419e4acbe0dbed8f558d95ced0e3. Thanks, Chris > Taiju HIGASHI writes: > >> * guix/import/gem.scm: (rubygems-fetch, gem->guix-package) >> (gem-recursive-import): Fix to fetch the specified version of the gem. >> * guix/scripts/import/gem.scm (show-help): Modify the help message. >> (guix-import-gem): Modify the version number to be passed to subsequent >> procedures >> * tests/gem.scm: Add tests. >> --- >> guix/import/gem.scm | 19 ++++-- >> guix/scripts/import/gem.scm | 39 +++++++------ >> tests/gem.scm | 113 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 148 insertions(+), 23 deletions(-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmMmAadfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfgXRAAhOA9BKhzCv0ht5XQyEoZzM2qme4G5An/ TulBSyyyfkmrt5NqsIBmaeaFM9c+qSv3xTDW4BVJPBu3UBjL27m+BVfu/xxorne+ XXgGVANJDINJXv6r5uV5Sr83RsXMTul4XmmZprugd/eU+uOqpPFjzKyYo1BesX3m RhVagKVCdlJIEbyUiVcRpBs8+2BFmG9pc6FWJ9IuIdll6HAAba1X++jwnYXE1Hln V4lWHNv/qXhS00mwXUAVT82MSdEEkGnJesKNEwrgPFvMTw6zJRNA8XHdzjIYj5xQ gBuPEBv+/BUt0WvE/mF7fIiDSd5sUcpUEKz3MXU08kbQlSiNaNmB08r94ppwpFK9 tZoIornyVdvOjHGx2o9hBP21Pl38ePaaMuWPzD3Ce5YaLKuDup2GnX7KQdgTUUbH QD3RyTZk5B5jOZWBBJaX/8O0KYYFpxqZwWx8Dr/V8YKpqWdaWOV2NmNbOs8Sw0l7 H2btmFDjNYL3XQJ2pC/bqwjy8Ld69Wjf9SRsbehS2VMclaUsaBR+8YQo8VItgRRE o8X2ryqkhfuxqs8TZe0gXoy1uF95mA6pkmDUVhkWTpo6qR5C0Ed+90ACGDFePj6G r7tU/H5QIYGEhbct167oGGQzgQmj40pkzMxdZFty6T+AfzDC2aJQRRvvPArjWvQY oHdO3oMv9K0= =vhj4 -----END PGP SIGNATURE----- --=-=-=--