From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 62314@debbugs.gnu.org
Cc: john.kehayias@protonmail.com
Subject: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
Date: Tue, 21 Mar 2023 10:34:47 +0100 [thread overview]
Message-ID: <87355y30so.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87a606c00u.fsf@protonmail.com> (John Kehayias via Guix-patches via's message of "Tue, 21 Mar 2023 02:26:44 +0000")
Hello,
John Kehayias via Guix-patches via <guix-patches@gnu.org> writes:
> Subject: [PATCH] gnu: emacs-buttercup: Fix build with native
> compilation.
Thank you.
> + (add-after 'unpack 'fix-spy-on-test
> + (lambda _
> + (substitute* "buttercup.el"
> + ;; The spy-on test fails with native compilation, which was
> + ;; fixed in v1.30 but with a variable name for Emacs newer
> + ;; than 28.2. Add in the same fix with the current variable
> + ;; name. Upstream bug and fix:
> + ;; <https://github.com/jorgenschaefer/emacs-buttercup/issues/236>
> + (("61880") "61880\n(comp-enable-subr-trampolines nil)\n"))))
Nitpick: I'm surprised by the choice of your anchor: 61880 is at the end
of a comment. Wouldn't
(("\\(native-comp-enable-subr-trampolines nil\\)" all)
(string-append all "\n(comp-enable-subr-trampolines nil)"))
be more explicit?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-03-21 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 2:26 [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation John Kehayias via Guix-patches via
2023-03-21 9:34 ` Nicolas Goaziou [this message]
2023-03-24 19:38 ` John Kehayias via Guix-patches via
2023-03-24 9:17 ` bug#62314: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87355y30so.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=62314@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).