From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2BEKKld6GWQfLAEASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 10:35:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MCL3KVd6GWRgLgAAauVa8A (envelope-from ) for ; Tue, 21 Mar 2023 10:35:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88AF0406A for ; Tue, 21 Mar 2023 10:35:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peYOX-00054f-5D; Tue, 21 Mar 2023 05:35:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peYOV-000546-Cp for guix-patches@gnu.org; Tue, 21 Mar 2023 05:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peYOU-0004j6-RA for guix-patches@gnu.org; Tue, 21 Mar 2023 05:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peYOU-0002XC-Ml for guix-patches@gnu.org; Tue, 21 Mar 2023 05:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 09:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62314@debbugs.gnu.org Cc: john.kehayias@protonmail.com X-Debbugs-Original-To: John Kehayias via Guix-patches via X-Debbugs-Original-Cc: John Kehayias , 62314@debbugs.gnu.org Received: via spool by 62314-submit@debbugs.gnu.org id=B62314.16793913019731 (code B ref 62314); Tue, 21 Mar 2023 09:35:02 +0000 Received: (at 62314) by debbugs.gnu.org; 21 Mar 2023 09:35:01 +0000 Received: from localhost ([127.0.0.1]:57680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peYOT-0002Wl-8x for submit@debbugs.gnu.org; Tue, 21 Mar 2023 05:35:01 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peYOP-0002WI-2c for 62314@debbugs.gnu.org; Tue, 21 Mar 2023 05:34:57 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id E7157FF80C; Tue, 21 Mar 2023 09:34:47 +0000 (UTC) From: Nicolas Goaziou References: <87a606c00u.fsf@protonmail.com> Date: Tue, 21 Mar 2023 10:34:47 +0100 In-Reply-To: <87a606c00u.fsf@protonmail.com> (John Kehayias via Guix-patches via's message of "Tue, 21 Mar 2023 02:26:44 +0000") Message-ID: <87355y30so.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679391319; a=rsa-sha256; cv=none; b=nEeHO837KaoPmTLxGW/PoK/S7eDmfV7mS/xuoj6Kb+NQG60eMuqmSqngJycTXsxEBYPS0q wiBh5yrCgByMEz3+DAnjKnL0J0GtgkNWSV0GwXdus8QcCEZj12BiPTwiOH59Vj7j5UaFX2 VsqzpRVd/379ZpeW2iUJqOB7m/W41PebPuI8rggAQyP3UQboXRMIhVwtyCu3ypOapTAn62 rmzar1/9hZBotJgHHV5IX6j95rXdgPX5ElUdaIgJ+vOjrAkp1kCTJ4LnfERZw/aLjemPkk Vu5WoaAUqhTqCsYIRPkag47Qqef0+uCTPsQ1GKP1V2g1bs1jGe3oB8pjwmKoag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679391319; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=afhfPiMA0ZtT1th1N4Rn2ATX9JS8sPfhCba8xX7C2Ow=; b=cvW6iInK62WLSvF5KxB0pWAnFp5CLZBK06YGTKUYgS7oEuUzxjLfKsdHDYCWIy9EZSlYIL iFa7nAehZPhBVJGQ2QV3pE7cUCjBf5F6X3R4kwOlHjDNJK3C1eJfXWFzpCB2AYL1pnwNi+ 1HsG6AZEW+v5NQyuPrho6boN9gh82R44dFV0ih6t9zKulyw5mwGy5e/NbhGTHrs5zEVWGp BIJHWLuJvKrhEXqa5jb8HtDsEeCpocqJXp16ClKQ0ziDSDUiuWYD2UEpYAKOLLFliMy6QN qbY/VPasYG7IBucbKTvTULGOIhBi42Rg+P7LUcy7CeSPY9Fu+Do5dWr8qhTnHA== X-Migadu-Spam-Score: -3.35 X-Spam-Score: -3.35 X-Migadu-Queue-Id: 88AF0406A Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: Hc36WhsfKKwu Hello, John Kehayias via Guix-patches via writes: > Subject: [PATCH] gnu: emacs-buttercup: Fix build with native > compilation. Thank you. > + (add-after 'unpack 'fix-spy-on-test > + (lambda _ > + (substitute* "buttercup.el" > + ;; The spy-on test fails with native compilation, which was > + ;; fixed in v1.30 but with a variable name for Emacs newer > + ;; than 28.2. Add in the same fix with the current variable > + ;; name. Upstream bug and fix: > + ;; > + (("61880") "61880\n(comp-enable-subr-trampolines nil)\n")))) Nitpick: I'm surprised by the choice of your anchor: 61880 is at the end of a comment. Wouldn't (("\\(native-comp-enable-subr-trampolines nil\\)" all) (string-append all "\n(comp-enable-subr-trampolines nil)")) be more explicit? Regards, -- Nicolas Goaziou