From: "Ludovic Courtès" <ludo@gnu.org>
To: Hilton Chain <hako@ultrarare.space>
Cc: Tobias Geerinckx-Rice <me@tobias.gr>,
67017@debbugs.gnu.org, Leo Famulari <leo@famulari.name>
Subject: [bug#67017] [PATCH v2] gnu: Add iptables-nft.
Date: Sun, 26 Nov 2023 23:34:22 +0100 [thread overview]
Message-ID: <8734ws16vl.fsf@gnu.org> (raw)
In-Reply-To: <c71870c7300ae57026afbc2c0eda9b89c7981688.1699802445.git.hako@ultrarare.space> (Hilton Chain's message of "Sun, 12 Nov 2023 23:28:19 +0800")
Hi,
Hilton Chain <hako@ultrarare.space> skribis:
> * gnu/packages/linux.scm (iptables-nft): New variable.
>
> Change-Id: I281514fcf05e70b4d62f374269c50c76bb676f78
[...]
> +(define-public iptables-nft
> + (package
> + (inherit iptables)
> + (name "iptables-nft")
> + (source #f)
> + (build-system copy-build-system)
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (delete 'unpack)
> + (replace 'install
> + (lambda* (#:key inputs #:allow-other-keys)
> + (for-each
> + (lambda (command-path)
> + (let ((link-path (string-append #$output command-path)))
> + (mkdir-p (dirname link-path))
> + (symlink (search-input-file inputs "sbin/xtables-nft-multi")
> + link-path)))
> + (apply append
> + '("/bin/iptables-xml")
> + (map (lambda (xtables)
> + (list (string-append "/sbin/" xtables)
> + (string-append "/sbin/" xtables "-restore")
> + (string-append "/sbin/" xtables "-save")))
> + '("arptables"
> + "ebtables"
> + "iptables"
> + "ip6tables")))))))))
> + (inputs (list iptables))
> + (native-inputs '())))
I think we at least need ‘synopsis’ to clarify what this is about
compared to ‘iptables’.
Apart from that it LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2023-11-26 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 14:36 [bug#67017] [PATCH] gnu: Add iptables-nft Hilton Chain via Guix-patches via
2023-11-12 15:28 ` [bug#67017] [PATCH v2] " Hilton Chain via Guix-patches via
2023-11-26 22:34 ` Ludovic Courtès [this message]
2023-12-09 12:32 ` Hilton Chain via Guix-patches via
2023-12-19 13:52 ` bug#67017: Close: " Hilton Chain via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ws16vl.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=67017@debbugs.gnu.org \
--cc=hako@ultrarare.space \
--cc=leo@famulari.name \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).