From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:403:58f0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms8.migadu.com with LMTPS
	id oDm8HiTIY2UNFwAAauVa8A:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 26 Nov 2023 23:35:16 +0100
Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id oDm8HiTIY2UNFwAAauVa8A
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 26 Nov 2023 23:35:16 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 2B20641026
	for <larch@yhetil.org>; Sun, 26 Nov 2023 23:35:16 +0100 (CET)
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=G6P+JEgG;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1701038116;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=qcFEGvrUGtdcWtaVZ7I0xgjUD+WKZTOYkEkH7f6bkoI=;
	b=M1IGTwML8aORHgq4g4nHfOd6zuyBLCw3taVSP9PTWzlGzcKLRq9tMEpMAl5qJM3Bv5sePb
	GGJd5rjNNfPmhDntlP+OqWE///6MMd3m0cn6A0jUEAn0JI5HmC2dBkYsocuU8ZaU8n/C+x
	qFVIWz2OG2gl5RR8qNYaRM6nmPOW9H5U4ROwkpX0jfXhzpB4+hvE6W8J7dAyf6WMkZL/Lw
	+p332qnaYMI3x5rhjtbsPHtc1FVFuaL3gSLCWr1UX9PYbhEG+jgm4wo7PKmmLGlwouBhdv
	S+NWlzibcKhZahWqXDP/qkZ9rqltS8YKDLz4yiJkoXfZc92zNT8/bjqnG+z4YA==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701038116; a=rsa-sha256; cv=none;
	b=l6iBlV3REM0u2CNXRlr+5TcgOFcPUNSuSK6jnsY7AbYp7MsiPsM7t8XDmShpDiDgIYiIFe
	IKMUhfh0dONqwUtXG8pyPVm+6Jsi/46vbmRihn4eGV5/ENWdN1BJy938OKQfeTy3z89IJU
	zfp0RSoWd+0ImqsrqVOczhqwXV4U3hChKTHxXsnBFb12oQNW7wZSU/ExYjiD3WhYpGfMSS
	ivudV9d73RKOuKyLuMbmiuqsSUDIMzuotIMUXrTvQGyrX6WaPH+hAJYJkuauGdYqCyRYpb
	cWan8pYkk7dKkdmbjiqxEGu3Y6jhJazqw+hJv/k8sqI7uJVWiJ3FbzyFRimWEw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=G6P+JEgG;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1r7NiO-00010i-3Y; Sun, 26 Nov 2023 17:35:00 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r7NiK-00010K-KW
 for guix-patches@gnu.org; Sun, 26 Nov 2023 17:34:56 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r7NiK-0008BG-CV
 for guix-patches@gnu.org; Sun, 26 Nov 2023 17:34:56 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r7NiQ-0005fR-8H
 for guix-patches@gnu.org; Sun, 26 Nov 2023 17:35:02 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#67017] [PATCH v2] gnu: Add iptables-nft.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Sun, 26 Nov 2023 22:35:02 +0000
Resent-Message-ID: <handler.67017.B67017.170103808121737@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 67017
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Hilton Chain <hako@ultrarare.space>
Cc: Tobias Geerinckx-Rice <me@tobias.gr>, 67017@debbugs.gnu.org,
 Leo Famulari <leo@famulari.name>
Received: via spool by 67017-submit@debbugs.gnu.org id=B67017.170103808121737
 (code B ref 67017); Sun, 26 Nov 2023 22:35:02 +0000
Received: (at 67017) by debbugs.gnu.org; 26 Nov 2023 22:34:41 +0000
Received: from localhost ([127.0.0.1]:42838 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r7Ni4-0005eX-M3
 for submit@debbugs.gnu.org; Sun, 26 Nov 2023 17:34:40 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:37678)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1r7Ni2-0005eH-Ap
 for 67017@debbugs.gnu.org; Sun, 26 Nov 2023 17:34:39 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1r7Nhp-0008AH-Qm; Sun, 26 Nov 2023 17:34:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=qcFEGvrUGtdcWtaVZ7I0xgjUD+WKZTOYkEkH7f6bkoI=; b=G6P+JEgGkETmmmYlya8k
 DiyHHDRJ6fIUefGVPvJu5/D29yYiFj7QFHiJclcuQ+FJME9pP4yxTZL2NipZsTLrV/+1kMAlwQMly
 +b+bv8bD1zGoEqUJI7C2HgqS4QR5Gq5VSFAHTUDdNGJ5SpFIUCrHpaDdpJCzR3pff0cs9GNY/phuj
 /qTYhRNE6HVWV8UwDM397QTN4xFDCr/y7RLBTmF7up623tPXpXFehEj2xx8tqO6zKDbSdC9XU6GFD
 rufEeErXbPIshIsWTN1YdMs6+bqCg5tTY1x2Uwv3tVcMQLopA4Aurja65Oa6tQ+cUrpHJ32aol5cA
 BRYbzfV4bb+N8Q==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
In-Reply-To: <c71870c7300ae57026afbc2c0eda9b89c7981688.1699802445.git.hako@ultrarare.space>
 (Hilton Chain's message of "Sun, 12 Nov 2023 23:28:19 +0800")
References: <6655067807f1485e3a8e9bea0c8319c691c40340.1699540137.git.hako@ultrarare.space>
 <c71870c7300ae57026afbc2c0eda9b89c7981688.1699802445.git.hako@ultrarare.space>
Date: Sun, 26 Nov 2023 23:34:22 +0100
Message-ID: <8734ws16vl.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
X-Migadu-Scanner: mx11.migadu.com
X-Migadu-Spam-Score: -6.82
X-Spam-Score: -6.82
X-Migadu-Queue-Id: 2B20641026
X-TUID: yypXGushdWUl

Hi,

Hilton Chain <hako@ultrarare.space> skribis:

> * gnu/packages/linux.scm (iptables-nft): New variable.
>
> Change-Id: I281514fcf05e70b4d62f374269c50c76bb676f78

[...]

> +(define-public iptables-nft
> +  (package
> +    (inherit iptables)
> +    (name "iptables-nft")
> +    (source #f)
> +    (build-system copy-build-system)
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (delete 'unpack)
> +          (replace 'install
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (for-each
> +               (lambda (command-path)
> +                 (let ((link-path (string-append #$output command-path)))
> +                   (mkdir-p (dirname link-path))
> +                   (symlink (search-input-file inputs "sbin/xtables-nft-=
multi")
> +                            link-path)))
> +               (apply append
> +                      '("/bin/iptables-xml")
> +                      (map (lambda (xtables)
> +                             (list (string-append "/sbin/" xtables)
> +                                   (string-append "/sbin/" xtables "-res=
tore")
> +                                   (string-append "/sbin/" xtables "-sav=
e")))
> +                           '("arptables"
> +                             "ebtables"
> +                             "iptables"
> +                             "ip6tables")))))))))
> +    (inputs (list iptables))
> +    (native-inputs '())))

I think we at least need =E2=80=98synopsis=E2=80=99 to clarify what this is=
 about
compared to =E2=80=98iptables=E2=80=99.

Apart from that it LGTM, thanks!

Ludo=E2=80=99.