unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#69574] [PATCH 0/2] gnu: emacs-eldev: Update to 1.9.
@ 2024-03-06  0:35 Suhail Singh
  2024-03-06  0:48 ` [bug#69574] [PATCH 1/2] " Suhail Singh
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Suhail Singh @ 2024-03-06  0:35 UTC (permalink / raw)
  To: 69574; +Cc: Andrew Tropin, Katherine Cox-Buday, Liliana Marie Prikler


Hello Guix,

This series updates emacs-eldev to version 1.9 which provides the
"--use-emacsloadpath" option.  For packages developed using Eldev, this
simplifies evaluation of the test suite as demonstrated by the second
patch.

Cheers

Suhail (2):
  gnu: emacs-eldev: Update to 1.9.
  gnu: emacs-ox-tufte: Simplify test invocation.

 gnu/packages/emacs-xyz.scm | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)


base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
-- 
2.44.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#69574] [PATCH 1/2] gnu: emacs-eldev: Update to 1.9.
  2024-03-06  0:35 [bug#69574] [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Suhail Singh
@ 2024-03-06  0:48 ` Suhail Singh
  2024-03-06  0:50 ` [bug#69574] [PATCH 2/2] gnu: emacs-ox-tufte: Simplify test invocation Suhail Singh
  2024-03-07 10:43 ` bug#69574: [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Andrew Tropin via Guix-patches via
  2 siblings, 0 replies; 4+ messages in thread
From: Suhail Singh @ 2024-03-06  0:48 UTC (permalink / raw)
  To: 69574; +Cc: Andrew Tropin, Katherine Cox-Buday, Liliana Marie Prikler


* gnu/packages/emacs-xyz.scm (emacs-eldev): Update to 1.9.

Change-Id: I364f261a5d332793d7dd0b789e32a993fa749bd4
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e1d14ea4aa..903537acb5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23495,7 +23495,7 @@ (define-public emacs-peg
 (define-public emacs-eldev
   (package
     (name "emacs-eldev")
-    (version "1.8.2")
+    (version "1.9")
     (source
      (origin
        (method git-fetch)
@@ -23504,7 +23504,7 @@ (define-public emacs-eldev
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "108px7lnf39ngvb8rcqb9qh2amcbs1h22dbwd1q7js2np2nd132y"))))
+        (base32 "0mhp3m4d5na844nnv107j706552h0q6xs93jkp4rmqiig73kq17w"))))
     (build-system emacs-build-system)
     (arguments
      (list
-- 
2.44.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#69574] [PATCH 2/2] gnu: emacs-ox-tufte: Simplify test invocation.
  2024-03-06  0:35 [bug#69574] [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Suhail Singh
  2024-03-06  0:48 ` [bug#69574] [PATCH 1/2] " Suhail Singh
@ 2024-03-06  0:50 ` Suhail Singh
  2024-03-07 10:43 ` bug#69574: [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Andrew Tropin via Guix-patches via
  2 siblings, 0 replies; 4+ messages in thread
From: Suhail Singh @ 2024-03-06  0:50 UTC (permalink / raw)
  To: 69574; +Cc: Andrew Tropin, Katherine Cox-Buday, Liliana Marie Prikler


* gnu/packages/emacs-xyz.scm (emacs-ox-tufte): Simplify the test invocation
using the --use-emacsloadpath option in emacs-eldev@1.9.

Change-Id: Ie61a336251b2670872cc8d049cc1c62284b7f350
---
 gnu/packages/emacs-xyz.scm | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 903537acb5..7fa5df9202 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33691,22 +33691,7 @@ (define-public emacs-ox-tufte
      (list
       #:include #~(cons "^src/" %default-include)
       #:tests? #t
-      ;; <https://github.com/emacs-eldev/eldev/issues/99#issuecomment-1912637609>
-      #:test-command #~(list "eldev" "-X" "-dtTC" "test")
-      #:phases
-      #~(modify-phases %standard-phases
-          (add-after 'unpack 'configure-eldev
-            (lambda _
-              (setenv "HOME"
-                      (string-append (getcwd) "/.eldev"))
-              (with-output-to-file "Eldev-local"
-                (lambda _
-                  (format #t "~s"
-                          '(dolist (d (split-string (getenv
-                                                     "EMACSLOADPATH")
-                                                    ":" t))
-                                   (ignore-errors
-                                    (eldev-use-local-dependency d)))))))))))
+      #:test-command #~(list "eldev" "--use-emacsloadpath" "-dtTC" "test")))
     (native-inputs (list emacs-buttercup emacs-eldev))
     (propagated-inputs (list emacs-org))
     (home-page "https://github.com/ox-tufte/ox-tufte")
-- 
2.44.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#69574: [PATCH 0/2] gnu: emacs-eldev: Update to 1.9.
  2024-03-06  0:35 [bug#69574] [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Suhail Singh
  2024-03-06  0:48 ` [bug#69574] [PATCH 1/2] " Suhail Singh
  2024-03-06  0:50 ` [bug#69574] [PATCH 2/2] gnu: emacs-ox-tufte: Simplify test invocation Suhail Singh
@ 2024-03-07 10:43 ` Andrew Tropin via Guix-patches via
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Tropin via Guix-patches via @ 2024-03-07 10:43 UTC (permalink / raw)
  To: Suhail Singh, 69574-done; +Cc: Katherine Cox-Buday, Liliana Marie Prikler

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

On 2024-03-05 19:35, Suhail Singh wrote:

> Hello Guix,
>
> This series updates emacs-eldev to version 1.9 which provides the
> "--use-emacsloadpath" option.  For packages developed using Eldev, this
> simplifies evaluation of the test suite as demonstrated by the second
> patch.
>
> Cheers
>
> Suhail (2):
>   gnu: emacs-eldev: Update to 1.9.
>   gnu: emacs-ox-tufte: Simplify test invocation.
>
>  gnu/packages/emacs-xyz.scm | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)
>
>
> base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503

Thank you for the patches, builds succesfully, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=0f2eede9f1

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-03-07 10:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06  0:35 [bug#69574] [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Suhail Singh
2024-03-06  0:48 ` [bug#69574] [PATCH 1/2] " Suhail Singh
2024-03-06  0:50 ` [bug#69574] [PATCH 2/2] gnu: emacs-ox-tufte: Simplify test invocation Suhail Singh
2024-03-07 10:43 ` bug#69574: [PATCH 0/2] gnu: emacs-eldev: Update to 1.9 Andrew Tropin via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).