unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Baines <mail@cbaines.net>
Cc: 28600-done@debbugs.gnu.org
Subject: bug#28600: [PATCH] tests: install: Switch to modifying the gc-root-service-type.
Date: Tue, 26 Sep 2017 10:46:02 +0200	[thread overview]
Message-ID: <871smt26gl.fsf@gnu.org> (raw)
In-Reply-To: <20170926090048.72724ba9@cbaines.net> (Christopher Baines's message of "Tue, 26 Sep 2017 09:00:48 +0100")

Christopher Baines <mail@cbaines.net> skribis:

> On Tue, 26 Sep 2017 09:46:10 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:

[...]

>> What about:
>> 
>>   (services (cons (simple-service 'extra-root
>>                                   gc-root-service-type roots)
>>                   (operating-system-user-services os)))
>> 
>> This would make sure there’s always a single ‘gc-root-service-type’
>> instance, and we’re just extending it with additional roots, rather
>> than overriding what it does.
>
> That fixes this issue, but I'm not sure what it means for the tests. If
> the roots are not replaced, then the bare-bones-os will be present as
> well as the roots added for each test.

I think it’s OK, because that’s what we want to test: we want to test
the installation image with few modifications compared to what we’re
shipping.

Pushed as 945a8fc240dbc48e3e4e212ef527eadc70231d39.

Now to see if there are still issues?

Thanks!

Ludo’.

      reply	other threads:[~2017-09-26  8:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 19:58 [bug#28600] [PATCH] tests: install: Switch to modifying the gc-root-service-type Christopher Baines
2017-09-25 20:02 ` Christopher Baines
2017-09-26  8:39   ` Ludovic Courtès
2017-09-26  7:46 ` Ludovic Courtès
2017-09-26  8:00   ` Christopher Baines
2017-09-26  8:46     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871smt26gl.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28600-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).