From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46394)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dwlWD-0001CV-UW
	for guix-patches@gnu.org; Tue, 26 Sep 2017 04:47:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dwlWA-0004Im-N0
	for guix-patches@gnu.org; Tue, 26 Sep 2017 04:47:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50990)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dwlWA-0004IZ-JL
	for guix-patches@gnu.org; Tue, 26 Sep 2017 04:47:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dwlWA-0005Ro-Cq
	for guix-patches@gnu.org; Tue, 26 Sep 2017 04:47:02 -0400
Subject: bug#28600: [PATCH] tests: install: Switch to modifying the
	gc-root-service-type.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.28600.D28600.150641557420878.done@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170925195810.26912-1-mail@cbaines.net> <878th13nst.fsf@gnu.org>
	<20170926090048.72724ba9@cbaines.net>
Date: Tue, 26 Sep 2017 10:46:02 +0200
In-Reply-To: <20170926090048.72724ba9@cbaines.net> (Christopher Baines's
	message of "Tue, 26 Sep 2017 09:00:48 +0100")
Message-ID: <871smt26gl.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28600-done@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> On Tue, 26 Sep 2017 09:46:10 +0200
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

[...]

>> What about:
>>=20
>>   (services (cons (simple-service 'extra-root
>>                                   gc-root-service-type roots)
>>                   (operating-system-user-services os)))
>>=20
>> This would make sure there=E2=80=99s always a single =E2=80=98gc-root-se=
rvice-type=E2=80=99
>> instance, and we=E2=80=99re just extending it with additional roots, rat=
her
>> than overriding what it does.
>
> That fixes this issue, but I'm not sure what it means for the tests. If
> the roots are not replaced, then the bare-bones-os will be present as
> well as the roots added for each test.

I think it=E2=80=99s OK, because that=E2=80=99s what we want to test: we wa=
nt to test
the installation image with few modifications compared to what we=E2=80=99re
shipping.

Pushed as 945a8fc240dbc48e3e4e212ef527eadc70231d39.

Now to see if there are still issues?

Thanks!

Ludo=E2=80=99.