From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30328@debbugs.gnu.org
Subject: [bug#30328] [PATCH] gnu: Add emacs-browse-at-remote-gnu.
Date: Tue, 06 Feb 2018 19:47:13 +0300 [thread overview]
Message-ID: <871shynjzi.fsf@gmail.com> (raw)
In-Reply-To: <87k1vq5ec3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 06 Feb 2018 16:26:36 +0100")
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Hello Ludovic,
Thank you for review!
ludo@gnu.org (Ludovic Courtès) writes:
> What about simply adding the patch to ‘emacs-browse-at-remote’ if
> it’s committed upstream way?
I'm sorry, what do you mean by “committed upstream way”?
I kinda agree to move the patch to ‘emacs-browse-at-remote’, but if
somebody want to upgrade it, maybe he will need to recreate a patch.
WDYT?
> Also please make the .patch file name a bit shorter; see ‘guix lint’.
Ouch, I missed this because of “GUIX_PACKAGE_PATH”. Usually I unset
this when prepare a package for Guix collection, but forget this time.
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env env guix lint emacs-browse-at-remote-gnu
$ ./pre-inst-env env GUIX_PACKAGE_PATH= guix lint emacs-browse-at-remote-gnu
/home/natsu/src/guix-wip-emacs-browse-at-remote-gnu/gnu/packages/emacs.scm:6474:2:
emacs-browse-at-remote-gnu@0.9.0-1.31dcf77:
emacs-browse-at-remote-gnu-add-support-for-gnu-repositories.patch: file
name is too long
fetching CVE database for 2018...nu@0.9.0-1.31dcf77 [cve]...
--8<---------------cut here---------------end--------------->8---
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-02-07 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 21:44 [bug#30328] [PATCH] gnu: Add emacs-browse-at-remote-gnu Oleg Pykhalov
2018-02-06 15:26 ` Ludovic Courtès
2018-02-06 16:47 ` Oleg Pykhalov [this message]
2018-02-07 9:18 ` Ludovic Courtès
2018-02-07 16:37 ` Oleg Pykhalov
2018-02-07 21:41 ` Ludovic Courtès
2018-02-09 19:26 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871shynjzi.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=30328@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).