From: Ricardo Wurmus <rekado@elephly.net>
To: "Wiktor Żelazny" <wz@freeshell.de>
Cc: 37392-done@debbugs.gnu.org
Subject: bug#37392: [PATCH] gnu: Add r-assertr
Date: Fri, 13 Sep 2019 01:09:43 +0200 [thread overview]
Message-ID: <871rwlp0w8.fsf@elephly.net> (raw)
In-Reply-To: <20190912164457.28412-1-wz@freeshell.de>
Hi Wiktor,
> * gnu/packages/cran.scm (r-assertr): New variable
Thank you for your patch!
I made a couple of minor changes before pushing it to the repository’s
master branch.
> +(define-public r-assertr
> + (package
> + (name "r-assertr")
> + (version "2.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (cran-uri "assertr" version))
> + (sha256
> + (base32
> + "0g4ii6vhp0155a29ljhs64a09x0nzy5ybvwwchhk4mkcgsvnvfkj"))))
> + (build-system r-build-system)
> + (propagated-inputs
> + `(("r-dplyr" ,r-dplyr)
> + ("r-knitr" ,r-knitr) ; needed for vignette
I moved this to native-inputs, because it is not needed at runtime.
> + (synopsis "Assertive Programming for R Analysis Pipelines")
I changed this to use lower case.
> + (description
> + "Provides functionality to assert conditions that have to be met so that
> +errors in data used in analysis pipelines can fail quickly. Similar to
> +@code{stopifnot()} but more powerful, friendly, and easier for use in
> +pipelines.")
I used full sentences here.
> + (license (license:fsf-free "https://cran.r-project.org/web/licenses/MIT"))))
This is the Expat license, so I changed it to license:expat.
I also added punctuation to the commit message.
Thank you for your contribution and welcome to Guix!
--
Ricardo
prev parent reply other threads:[~2019-09-12 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 16:44 [bug#37392] [PATCH] gnu: Add r-assertr Wiktor Żelazny
2019-09-12 23:09 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rwlp0w8.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=37392-done@debbugs.gnu.org \
--cc=wz@freeshell.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).