From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:49788)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i8YE0-0000rL-SZ
 for guix-patches@gnu.org; Thu, 12 Sep 2019 19:10:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i8YDz-00008h-BD
 for guix-patches@gnu.org; Thu, 12 Sep 2019 19:10:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:35360)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i8YDz-00008A-2O
 for guix-patches@gnu.org; Thu, 12 Sep 2019 19:10:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i8YDy-0002Ka-Qm
 for guix-patches@gnu.org; Thu, 12 Sep 2019 19:10:02 -0400
Subject: bug#37392: [PATCH] gnu: Add r-assertr
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.37392.D37392.15683297938930.done@debbugs.gnu.org>
References: <20190912164457.28412-1-wz@freeshell.de>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190912164457.28412-1-wz@freeshell.de>
Date: Fri, 13 Sep 2019 01:09:43 +0200
Message-ID: <871rwlp0w8.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Wiktor =?UTF-8?Q?=C5=BBelazny?= <wz@freeshell.de>
Cc: 37392-done@debbugs.gnu.org


Hi Wiktor,

> * gnu/packages/cran.scm (r-assertr): New variable

Thank you for your patch!

I made a couple of minor changes before pushing it to the repository=E2=80=
=99s
master branch.

> +(define-public r-assertr
> +  (package
> +    (name "r-assertr")
> +    (version "2.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "assertr" version))
> +       (sha256
> +        (base32
> +         "0g4ii6vhp0155a29ljhs64a09x0nzy5ybvwwchhk4mkcgsvnvfkj"))))
> +    (build-system r-build-system)
> +    (propagated-inputs
> +     `(("r-dplyr" ,r-dplyr)
> +       ("r-knitr" ,r-knitr)             ; needed for vignette

I moved this to native-inputs, because it is not needed at runtime.

> +    (synopsis "Assertive Programming for R Analysis Pipelines")

I changed this to use lower case.

> +    (description
> +     "Provides functionality to assert conditions that have to be met so=
 that
> +errors in data used in analysis pipelines can fail quickly.  Similar to
> +@code{stopifnot()} but more powerful, friendly, and easier for use in
> +pipelines.")

I used full sentences here.

> +    (license (license:fsf-free "https://cran.r-project.org/web/licenses/=
MIT"))))

This is the Expat license, so I changed it to license:expat.

I also added punctuation to the commit message.

Thank you for your contribution and welcome to Guix!

--=20
Ricardo