From: "Ludovic Courtès" <ludo@gnu.org>
To: Tanguy Le Carrour <tanguy@bioneland.org>
Cc: 37598@debbugs.gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>
Subject: [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time.
Date: Mon, 14 Oct 2019 00:02:43 +0200 [thread overview]
Message-ID: <871rvg8fss.fsf@gnu.org> (raw)
In-Reply-To: <87eezt3q5r.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 04 Oct 2019 09:50:40 +0200")
Hi Tanguy,
Did you have a chance to look into Mathieu’s suggestions (below)?
We’re almost there so let’s make sure we don’t forget about this patch
series!
Thanks in advance,
Ludo’.
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> Hello Tanguy,
>
> Thanks for your patches. A few remarks (more details at
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html):
>
>> Subject: [PATCH 1/4] gnu: Add python-jinja2-time.
>>
>
> You need to add a commit message, compliant with ChangeLog format. You
> can find examples in commit history.
>
>> + (description
>> + "Jinja2 Extension for Dates and Times")
>
> Description should follow the rules dictated at
> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions,
> most specifically "Descriptions should take between five and ten
> lines. Use full sentences, and avoid using acronyms without first
> introducing them".
>
> Otherwise, your serie seems fine :)
>
> Thanks,
>
> Mathieu
next prev parent reply other threads:[~2019-10-13 22:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 12:13 [bug#37598] [PATCH 0/4] gnu: Add Cookiecutter and its inputs Tanguy Le Carrour
2019-10-03 12:16 ` [bug#37598] [PATCH 1/4] " Tanguy Le Carrour
2019-10-03 12:17 ` [bug#37598] [PATCH 2/4] " Tanguy Le Carrour
2019-10-03 12:18 ` [bug#37598] [PATCH 3/4] " Tanguy Le Carrour
2019-10-03 12:19 ` [bug#37598] [PATCH 4/4] " Tanguy Le Carrour
2019-10-04 7:00 ` [bug#37598] [PATCH 0/4] gnu: Add python-cookiecutter " Tanguy Le Carrour
2019-10-04 7:20 ` [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time Tanguy Le Carrour
2019-10-04 7:50 ` Mathieu Othacehe
2019-10-13 22:02 ` Ludovic Courtès [this message]
2019-10-14 7:09 ` Tanguy Le Carrour
2019-10-14 20:25 ` Ludovic Courtès
2019-10-15 12:28 ` bug#37598: " Mathieu Othacehe
2019-10-15 13:14 ` [bug#37598] " Tanguy Le Carrour
2019-10-04 7:21 ` [bug#37598] [PATCH 2/4] gnu: Add python-poyo Tanguy Le Carrour
2019-10-04 7:23 ` [bug#37598] [PATCH 3/4] gnu: Add python-whichcraft Tanguy Le Carrour
2019-10-04 7:24 ` [bug#37598] [PATCH 4/4] gnu: Add python-cookiecutter Tanguy Le Carrour
2019-10-14 14:29 ` [bug#37598] Updating patches Tanguy Le Carrour
2019-10-14 15:20 ` Mathieu Othacehe
2019-10-14 14:30 ` [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time Tanguy Le Carrour
2019-10-14 14:31 ` [bug#37598] [PATCH 2/4] gnu: Add python-poyo Tanguy Le Carrour
2019-10-14 14:31 ` [bug#37598] [PATCH 3/4] gnu: Add python-whichcraft Tanguy Le Carrour
2019-10-14 14:32 ` [bug#37598] [PATCH 4/4] gnu: Add python-cookiecutter Tanguy Le Carrour
2019-10-15 7:37 ` [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time Tanguy Le Carrour
2019-10-15 7:38 ` [bug#37598] [PATCH 2/4] gnu: Add python-poyo Tanguy Le Carrour
2019-10-15 7:40 ` [bug#37598] [PATCH 3/4] gnu: Add python-whichcraft Tanguy Le Carrour
2019-10-15 7:41 ` [bug#37598] [PATCH 4/4] gnu: Add python-cookiecutter Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rvg8fss.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37598@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).