From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48977) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJlxB-00077c-3x for guix-patches@gnu.org; Sun, 13 Oct 2019 18:03:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJlx8-0007WE-RY for guix-patches@gnu.org; Sun, 13 Oct 2019 18:03:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJlx7-0007VZ-ST for guix-patches@gnu.org; Sun, 13 Oct 2019 18:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJlx7-0007yN-Ns for guix-patches@gnu.org; Sun, 13 Oct 2019 18:03:01 -0400 Subject: [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20191003121316.irq3vdmu4ov6dygb@rafflesia> <20191004072040.fpwcb2lmeih2mvsv@rafflesia> <87eezt3q5r.fsf@gmail.com> Date: Mon, 14 Oct 2019 00:02:43 +0200 In-Reply-To: <87eezt3q5r.fsf@gmail.com> (Mathieu Othacehe's message of "Fri, 04 Oct 2019 09:50:40 +0200") Message-ID: <871rvg8fss.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tanguy Le Carrour Cc: 37598@debbugs.gnu.org, Mathieu Othacehe Hi Tanguy, Did you have a chance to look into Mathieu=E2=80=99s suggestions (below)? We=E2=80=99re almost there so let=E2=80=99s make sure we don=E2=80=99t forg= et about this patch series! Thanks in advance, Ludo=E2=80=99. Mathieu Othacehe skribis: > Hello Tanguy, > > Thanks for your patches. A few remarks (more details at > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html): > >> Subject: [PATCH 1/4] gnu: Add python-jinja2-time. >> > > You need to add a commit message, compliant with ChangeLog format. You > can find examples in commit history. > >> + (description >> + "Jinja2 Extension for Dates and Times") > > Description should follow the rules dictated at > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#S= ynopses-and-Descriptions, > most specifically "Descriptions should take between five and ten > lines. Use full sentences, and avoid using acronyms without first > introducing them". > > Otherwise, your serie seems fine :) > > Thanks, > > Mathieu